Date: Thu, 7 Feb 2008 15:00:08 GMT From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/120319: fsck on read-only root fs upgrades it to read-write Message-ID: <200802071500.m17F08jm075396@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/120319; it has been noted by GNATS. From: Yar Tikhiy <yar@comp.chem.msu.su> To: Jaakko Heinonen <jh@saunalahti.fi> Cc: bug-followup@FreeBSD.org Subject: Re: kern/120319: fsck on read-only root fs upgrades it to read-write Date: Thu, 7 Feb 2008 17:58:51 +0300 On Thu, Feb 07, 2008 at 12:19:48PM +0200, Jaakko Heinonen wrote: > > This happens because the kernel doesn't set the "ro" mount option > initially for mounts in vfs_mountroot_try() (vfs_mount.c). ffs_mount() > remounts a file system as read-write if the "ro" option is missing. > > Following patch adds the "ro" option for initial root mounts. It should > fix the problem. Could you verify that? You've hit the nail on the head! Now the question is: Which of the two functions should be fixed after all? Some parts of the system seem to rely solely on MNT_RDONLY to get a read-only mount, so it might be wrong for ffs_mount() to look for the "ro" option even if MNT_RDONLY is set in the mount flags. Any ideas? Thanks! -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802071500.m17F08jm075396>