Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Jun 2017 16:19:33 +0000 (UTC)
From:      Alan Cox <alc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r319540 - head/sys/kern
Message-ID:  <201706031619.v53GJX5F005501@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: alc
Date: Sat Jun  3 16:19:33 2017
New Revision: 319540
URL: https://svnweb.freebsd.org/changeset/base/319540

Log:
  The data type returned by vmoff() is too narrow in its range.  This could
  break the transmission of files longer than 4 GB on 32-bit architectures.
  
  Reviewed by:	glebius, kib
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D10019

Modified:
  head/sys/kern/kern_sendfile.c

Modified: head/sys/kern/kern_sendfile.c
==============================================================================
--- head/sys/kern/kern_sendfile.c	Sat Jun  3 16:18:50 2017	(r319539)
+++ head/sys/kern/kern_sendfile.c	Sat Jun  3 16:19:33 2017	(r319540)
@@ -207,12 +207,12 @@ xfsize(int i, int n, off_t off, off_t len)
 /*
  * Helper function to get offset within object for i page.
  */
-static inline vm_offset_t
+static inline vm_ooffset_t
 vmoff(int i, off_t off)
 {
 
 	if (i == 0)
-		return ((vm_offset_t)off);
+		return ((vm_ooffset_t)off);
 
 	return (trunc_page(off + i * PAGE_SIZE));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201706031619.v53GJX5F005501>