Date: Thu, 17 Sep 2015 10:07:35 +0100 From: David Chisnall <theraven@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> In-Reply-To: <55FA69BD.10507@selasky.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Sep 2015, at 08:20, Hans Petter Selasky <hps@selasky.org> wrote: > > On 09/17/15 00:05, Gleb Smirnoff wrote: >> Weren't you explicitly asked not to touch this system without a proper >> review and discussion? > > Adding a new function is not touching code. Adding a new interface to an existing core subsystem is most definitely touching the system. I would expect *anyone* making a change like this to have both the design and code reviewed for sanity checking. For someone who has already been required to have explicit review of any changes to the subsystem to skip this step shows a flagrant disregard for the project’s policies and best practices. David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0952027A-5276-487D-99B8-74747B0EEF5D>