Date: Mon, 20 Aug 2012 11:54:11 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-multimedia@freebsd.org, kan@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de>, Kevin Oberman <kob6558@gmail.com>, FreeBSD Ports <ports@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: __FreeBSD_version bump? (was: Re: vlc 2.0.3 ProjectM path fix) Message-ID: <20120820115411.4134af08@kan.dyndns.org> In-Reply-To: <20120820101510.GJ33100@deviant.kiev.zoral.com.ua> References: <20120813211109.GA71682@triton8.kn-bremen.de> <20120813214651.GA72570@triton8.kn-bremen.de> <5029D6AE.4050205@gwdg.de> <20120814114214.GB94259@triton8.kn-bremen.de> <502A8206.4090505@gwdg.de> <20120814192453.GA8026@triton8.kn-bremen.de> <502AAD0E.2070909@FreeBSD.org> <20120815120143.GB33206@triton8.kn-bremen.de> <CAN6yY1tua2jWu2k7nF-5DfBsvn19O1XSdaDR%2BU2RwbDjafJ33g@mail.gmail.com> <20120818204510.GA70765@triton8.kn-bremen.de> <20120820101510.GJ33100@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/CaBsWPFxGA19IQqehbrwp+F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 20 Aug 2012 13:15:10 +0300 Konstantin Belousov <kostikbel@gmail.com> wrote: > On Sat, Aug 18, 2012 at 10:45:10PM +0200, Juergen Lock wrote: > > On Wed, Aug 15, 2012 at 10:09:59AM -0700, Kevin Oberman wrote: > > > On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock > > > <nox@jelal.kn-bremen.de> wrote: > > > > On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote: > > > >> ... > > > >> >> I think I got it: It is only a problem of configuring in > > > >> >> the running vlc. You have to set the right path under > > > >> >> 'Settings','All','Audio','Visualizing','projectM'. That's > > > >> >> all ;-) > > > >> >> > > > >> > Aah-haah! :) I've fixed the default paths and made a new > > > >> > patch: > > > >> > > > > >> > http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch > > > >> > > > > >> > > > >> > > > >> >From your patch: > > > >> > workaround is to deinstall the old vlc-1.x version before > > > >> > building the new one. > > > >> > > > >> What about a conflict line ? > > > >> CONFLICTS_BUILD=3D${PORTNAME}-1.* > > > >> > > > >> This allows users to fetch the source but they have to > > > >> deinstall the old version before building the new one. > > > > > > > > Hm well the rtld bug this workaround is for only affects the > > > > pulseaudio and notify knobs, and the workaround doesn't work for > > > > the notify knob so it would only cover half the cases, and also > > > > checking if this is needed in the port would require a > > > > __FreeBSD_version bump which is probably overkill for this bug. > > >=20 > > > And why is it overkill? I regularly see comments about not > > > wanting to bump __FreeBSD_version, but it's just an integer > > > (though presented as a fixed-point fraction). There is no > > > shortage and I never have understood why people are so hesitant > > > to change it when there is a real, even if fairly small benefit > > > from the bump. > >=20 > > Hmm. Alexander, what do you think? >=20 > Not being Alexander, but appeared on Cc:. >=20 > IMO, bumping __FreeBSD_version should not be done frivolous, and > routine bug fixes are definitely not the good reason to bump. >=20 > For one, users of HEAD or stable are assumed to run tip of the branch. > If you want defined point of the branch, use release. With this POV, > the usefulness of the bump for bug fix is only a week or two. >=20 > Second, bump of __FreeBSD_version signifies major incompatibility > between pre-bumped tree and current one. In the kernel, each bump of > version in HEAD means that new modules cannot be loaded into new > kernel. >=20 > Bumping for bug fixes is a misuse of the mechanism which was put there > to provide information about major changes in system. For small or > detectable items, use autoconf-like runtime (or build-time *) tests. >=20 > * - Usually, the tests must be run-time, and not build-time. This bug > is greatly amplified by use of __FreeBSD_version. The case that > initiated the discussion is probably the first time I ever saw the > when build-time test makes some sense. I agree with Konstantin and I do not see the point to bump the version just to serve fleeting needs of -stable or -current branch users - their problems will be gone with upgrade to the tip of the respective branch and this is the first thing they are expected to do before reporting a bug anyway. --=20 Alexander Kabaev --Sig_/CaBsWPFxGA19IQqehbrwp+F Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iD8DBQFQMl2uQ6z1jMm+XZYRAiksAJ4uOLssIr8Ns79NR5+Sflbogh6dHACdEL19 +1cir6jiiTHHFSpII+nZqjY= =VOZA -----END PGP SIGNATURE----- --Sig_/CaBsWPFxGA19IQqehbrwp+F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120820115411.4134af08>