Date: Wed, 22 Aug 2001 19:06:34 -0700 From: Peter Wemm <peter@wemm.org> To: Paul Richards <paul@freebsd-services.com> Cc: Jordan Hubbard <jkh@FreeBSD.org>, silby@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_seq.h tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_var.h Message-ID: <20010823020634.6090B380F@overcee.netplex.com.au> In-Reply-To: <253280000.998524932@lobster.originative.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Paul Richards wrote: > --On Wednesday, August 22, 2001 16:55:26 -0700 Jordan Hubbard > <jkh@freebsd.org> wrote: > > > We've been waiting for this particular change for a long time now and > > the impact was judged less severe then continuing to get beat up over > > not having it. If I called it right, everyone will probably just > > happily use it and I'll not hear another thing about it. If I called > > it wrong, I'll get flamed to toast. Such is the life of the RE. :) > > It's a *very* late call for code that has never seen the light of day > before (and the authors testing doesn't count in this context). > > No offense Mike, since I'm sure you've tested it a lot, but this is a > significant enough change that such a late merge to -stable without any > testing at all in -current merits at least a questioning email. Dont forget, having something in current for a while doesn't guarantee anything. Witness the PCI interrupt steering and pcibios stuff. It sat in -current for a whole *year* before it got MFC'ed and discovered that it doesn't work on a sufficient number of machines for it to be a showstopper. Yes, it is nice to set it sit in current for a while so people can *look* at it, but dont pretend that it is going to be well tested. In some areas it will, but it is no guarantee. One would have though that boot time probe/attach of pci stuff would have got tested, but it would seem that not even 12 months of "testing" in -current is enough. I'm not aiming this gripe at Paul specifically, but please dont spread the myth that some arbitary "test period" in -current is going to magically validate anything. And yes, I undertand your alarm at this particular commit. But it cannot be any worse than what is there now (ie: random with complete disregard to the ISS sequence space). There is no real downside. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010823020634.6090B380F>