Date: Fri, 31 Jul 2015 16:06:33 -0600 From: Warner Losh <imp@bsdimp.com> To: Glen Barber <gjb@FreeBSD.org> Cc: Larry Rosenman <ler@lerctr.org>, Benno Rice <benno@freebsd.org>, freebsd-current@freebsd.org Subject: Re: pmspcv panic on boot on this box Message-ID: <E7310E4C-44A7-4910-BD89-9A137EC4938A@bsdimp.com> In-Reply-To: <20150731213255.GC1304@FreeBSD.org> References: <20150731102721.GA824@oldtbh.lerctr.org> <20150731133214.GV90754@FreeBSD.org> <14ee48f81d8.2846.a6b027662ce9a8103f88b1e74d3c5524@lerctr.org> <9B59F252-D41D-4714-A983-356E525359FD@bsdimp.com> <14ee53e57a8.2846.a6b027662ce9a8103f88b1e74d3c5524@lerctr.org> <CBC7A977-EF25-44CF-B50B-6EAB62331866@bsdimp.com> <20150731204137.GA832@oldtbh.lerctr.org> <20150731204403.GB1304@FreeBSD.org> <d451b0f866624bad2d5f2f6a6aef517f@thebighonker.lerctr.org> <E859ED3F-404A-4996-8C60-609F16192012@bsdimp.com> <20150731213255.GC1304@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_CEF8E874-6CA3-4ACF-B043-B2C44D85B352 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 31, 2015, at 3:32 PM, Glen Barber <gjb@FreeBSD.org> wrote: >=20 > On Fri, Jul 31, 2015 at 03:11:15PM -0600, Warner Losh wrote: >>=20 >>> On Jul 31, 2015, at 2:46 PM, Larry Rosenman <ler@lerctr.org> wrote: >>>=20 >>> On 2015-07-31 15:44, Glen Barber wrote: >>>> On Fri, Jul 31, 2015 at 03:41:37PM -0500, Larry Rosenman wrote: >>>>> We have a winner -- rebuilt with just this patch, and GENERIC with = pmspcv, >>>>> and we boot. >>>> Larry, thank you so much for your willingness to test this. It is >>>> greatly appreciated. >>>> Glen >>> Absolutely my pleasure. I appreciate ALL that the re@ and = developers folks do for FreeBSD. >>>=20 >>> Best OS ever :) >>=20 >> Thanks Larry. I=E2=80=99ll cleanup the patch (I=E2=80=99d never = knowing commit #if 0 w/o a good reason) >> and get it reviewed. The good news is that we can make a fairly = low-risk patch for 10.2R >> I think, subject to the blessings of our benevolent re@ overlords... >>=20 >=20 > My gut instinct is to leave the driver in 10.2 as-is for now, as I'd > like to make sure this driver does not present more pain (and = certainly > before being re-enabled in GENERIC on stable/10), since this situation > could have been much more of a disaster. >=20 > Personally, I'd like to keep it out of GENERIC on stable/10 for at = least > a month, while things get shaken out in head. >=20 > That said, once the issues are flushed out, re@ will be happy to issue > an EN for 10.2 to resolve the existing (and any new) issues with this. You=E2=80=99re the boss. I can understand the skepticism given how badly = the current code misunderstands newbus. This instance is quite easy to fix (I should = have something in -current in a day or two). Fortunately, the series of = errors would only cause a problem if you had two Adaptec devices in your system (and not = just one). Since it is available as a module, perhaps a note explaining there was a = problem with the auto-probing code so it was omitted from GENERIC, but if you = have one of these devices put pms_load=3DYES in your loader.conf file. But only if = you don=E2=80=99t have any other devices with the Adaptec vendor ID (since if you want to load = pms, it is because you presumably have one of these cards). The path to doom is the = second trip into probe after the first trip into probe failed. I=E2=80=99d be inclined to take a middle ground and fix the driver (and = therefore the module) in 10.2R, but not put it in GENERIC until 10.3, but hey that=E2=80=99s = just me. Interested parties should check out https://reviews.freebsd.org/D3263 = for correctness or for testing. Warner --Apple-Mail=_CEF8E874-6CA3-4ACF-B043-B2C44D85B352 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVu/FqAAoJEGwc0Sh9sBEAprgP/jqe2P1yPHySRVIZSpR/tdZx QfQbTNkl54YcgF/j4j4B+k0anWUoHJ8m9fkCXueP5g/F42PJYVMqUq9tqf+biJgx b1mKHvbR45Ca8Ud9Rzm/vQno6nPEXfHnu9nsrux/ksCcbZqRYjD8CTLKgi9iA5Z8 hZ8sAe1cJE2oK5XnJtoClHhssY8YK3eDTdTIh9spL58u8lX18iGWocXG6O1ydgZa qmzPaWBwPf7CuU+JrjxxlEPq0gRPLRvHlEsfRzaTQ9CZaPTwgvjFjNmWZcQEZTau uozTehUrNFCaJAJb4ANA8Q40rpfGBzSU7MhIPPETrsp93QSV2S4WVgamABqmyItz /jiXPzg//d6URkjvcT1ciS+gxvFNtBcaaTtiqXiaHa8x3vo1rxbDXrJbZDDJA2Gv ogBend9CftwsNFx4qD367F7ME55j5Z4fQ8yD5kS9Sx6iLaWqqDYZv/WZaAueSbFG sDdx4hgSzRlZicDBJU211WO360RpC55mhqRoBP2s5JDLjl+YiQUfFtXaDXOz1mIX 0vWfjzs1wV/UHIwDc0LE9O2cu1qG6HBqUEDRHJcqpACpoEhffr8xRLX6G3WwzkIk 72+LkqwSsBfnQ5Xp+BPI1nDPUPL8fr82QlfgVZl+Cifq2gwytVaLMZrNsFCfAzCd 9DE4yrMbeMcRKfEFckjl =NzAp -----END PGP SIGNATURE----- --Apple-Mail=_CEF8E874-6CA3-4ACF-B043-B2C44D85B352--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E7310E4C-44A7-4910-BD89-9A137EC4938A>