Date: Mon, 21 Oct 1996 10:30:25 +0900 (JST) From: Michael Hancock <michaelh@cet.co.jp> To: phk@FreeBSD.ORG Cc: current@FreeBSD.ORG Subject: Re: <sys/queue.h> Message-ID: <Pine.SV4.3.93.961021101256.20316C-100000@parkplace.cet.co.jp> In-Reply-To: <24020.845822819@critter.tfs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 20 Oct 1996, Poul-Henning Kamp wrote:
>
> As much as I like this file there's one detail that I hate:
>
> /*
> * Singly-linked List definitions.
> */
> #define SLIST_HEAD(name, type) \
> struct name { \
> - struct type *slh_first; /* first element */ \
> + type *slh_first; /* first element */ \
> }
If anything should be changed, it should be the name 'type'. It's
miss-used here:
#define SLIST_HEAD(name, tag) \
struct name { \
struct tag *slh_first; \
}
Regards,
Mike Hancock
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.93.961021101256.20316C-100000>