Date: Fri, 25 Feb 2005 10:17:53 +0000 (UTC) From: Maxim Sobolev <sobomax@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern imgact_shell.c Message-ID: <200502251017.j1PAHroL051596@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
sobomax 2005-02-25 10:17:53 UTC
FreeBSD src repository
Modified files:
sys/kern imgact_shell.c
Log:
o Replace two while {} do loops with more appropriate do {} while loops. This
doesn't change functionality, but makes code more logical.
Obtained from: DrafonFlyBSD
o Use VOP_GETATTR() to obtain actual size of file and parse no more than that.
Previously, we parsed MAXSHELLCMDLEN characters regardless of the actual file
size. This makes the following working:
$ printf '#!/bin/echo' > /tmp/test.sh
$ chmod 755 /tmp/test.sh
$ /tmp/test.sh
Previously, attempts to execve() that shell script has been failing with bogus
ENAMETOOLONG.
PR: kern/64196
Submitted by: Magnus B.ckstr.m <b@etek.chalmers.se>
Revision Changes Path
1.32 +27 -12 src/sys/kern/imgact_shell.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502251017.j1PAHroL051596>