Date: Wed, 01 May 2024 13:19:09 -0400 From: gnn <gnn@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e60ca52b72e5 - main - Out of tree modules should be built with DTrace by default. Message-ID: <C98B4A99-2B5A-462A-A24F-7F8A8A3D8351@freebsd.org> In-Reply-To: <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org> References: <202405011701.441H17Wf008095@gitrepo.freebsd.org> <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 May 2024, at 13:08, Jessica Clarke wrote: > On 1 May 2024, at 18:01, George V. Neville-Neil <gnn@FreeBSD.org> wrote= : >> >> The branch main has been updated by gnn: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3De60ca52b72e518f8394615b= dad9cd9c85764caa2 >> >> commit e60ca52b72e518f8394615bdad9cd9c85764caa2 >> Author: George V. Neville-Neil <gnn@FreeBSD.org> >> AuthorDate: 2024-05-01 17:00:52 +0000 >> Commit: George V. Neville-Neil <gnn@FreeBSD.org> >> CommitDate: 2024-05-01 17:00:52 +0000 >> >> Out of tree modules should be built with DTrace by default. >> --- >> share/examples/modules/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/share/examples/modules/Makefile b/share/examples/modules/= Makefile >> index 0f0a2fb01e8a..bc7f6f6a57ac 100644 >> --- a/share/examples/modules/Makefile >> +++ b/share/examples/modules/Makefile >> @@ -4,3 +4,5 @@ KMOD=3D skel >> SRCS=3D skel.c >> >> .include <bsd.kmod.mk> >> + >> +CFLAGS:=3D ${CFLAGS:N -DKDTRACE_HOOKS} > > I believe this is a no-op in practice, and definitely doesn=E2=80=99t d= o what > you want? :N is "select all words that don=E2=80=99t match the given pa= ttern", > so this expands to CFLAGS with any instances of " -DKDTRACE_HOOKS" > removed. But that=E2=80=99s a no-op, because the space won=E2=80=99t be= present in the > word itself unless you start quoting things, and it then wouldn=E2=80=99= t be a > valid compiler flag. > Interesting because it built with the hooks out of tree. Let me clean it= up anyways. Thanks, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C98B4A99-2B5A-462A-A24F-7F8A8A3D8351>