Date: Thu, 5 Dec 2019 08:47:11 -0800 From: John Baldwin <jhb@FreeBSD.org> To: rgrimes@freebsd.org, Vincenzo Maffione <vmaffione@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve Message-ID: <a6847442-59bf-a1e5-2d3c-40e51814570a@FreeBSD.org> In-Reply-To: <201912050535.xB55ZQxt042493@gndrsh.dnsmgr.net> References: <201912050535.xB55ZQxt042493@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/4/19 9:35 PM, Rodney W. Grimes wrote: >> I see, thanks for the pointers. >> It looks like cfmakeraw() and tcsetattr() were what I was looking for. >> A bhyve-specific printf wrapper looks the right solution to me. >> I can try to sketch a patch for you guys to review, if that's useful. >> >> Cheers, >> Vincenzo > > Meanwhile could you please revert the commit, and add a note to > D22552 to the effects that this was not the right solution? I don't think we have to revert as it isn't that big of a deal. Just fixing it going forward is probably fine. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a6847442-59bf-a1e5-2d3c-40e51814570a>