Date: Tue, 3 Aug 2021 15:43:36 +0200 From: Markus Wipp <mw@wipp.bayern> To: Michael Gmelin <freebsd@grem.de> Cc: freebsd-ports@freebsd.org, portmgr@freebsd.org Subject: Re: Issues with security/step-cli Message-ID: <993AB7FE-D206-49E6-B432-3431017D40DD@wipp.bayern> In-Reply-To: <20210803153141.61e87955@bsd64.grem.de> References: <9F64FFEB-6525-49EA-9BDF-C60E64878261@wipp.bayern> <70C8D71B-880A-4D11-83CD-C680E7BF4898@grem.de> <B9D8B549-618A-453F-942E-C0AFB0317C39@wipp.bayern> <20210803143418.23df9eca@bsd64.grem.de> <04D905BA-565F-41DE-8AE8-44E500F50E89@wipp.bayern> <20210803153141.61e87955@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_079AEBE3-A4CE-4D3E-B31A-CC4945E41DE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 3. Aug 2021, at 15:31, Michael Gmelin <freebsd@grem.de> wrote: >=20 >=20 >=20 > On Tue, 3 Aug 2021 14:53:07 +0200 > Markus Wipp <mw@wipp.bayern <mailto:mw@wipp.bayern>> wrote: >=20 >>> On 3. Aug 2021, at 14:34, Michael Gmelin <freebsd@grem.de> wrote: >>>=20 >>>=20 >>>=20 >>> On Tue, 3 Aug 2021 13:41:42 +0200 >>> Markus Wipp <mw@wipp.bayern> wrote: >>>=20 >>>> Sure. I attached you the diff. >>>>=20 >>>>=20 >>>>> On 3. Aug 2021, at 13:35, Michael Gmelin <freebsd@grem.de> wrote: >>>>>=20 >>>>>=20 >>>>>=20 >>>>>> On 3. Aug 2021, at 13:29, Markus Wipp <mw@wipp.bayern> wrote: >>>>>>=20 >>>>>> =EF=BB=BFHi all,=20 >>>>>>=20 >>>>>> I=E2=80=99m the maintainer of the security/step-cli port and = I=E2=80=99m >>>>>> currently facing some issues, I seem to be unable to fix. >>>>>>=20 >>>>>> I currently try to create the patch for the latest version 0.16.1 >>>>>>=20 >>>>>> I did the following: >>>>>>=20 >>>>>> 1) I removed all files in /usr/ports/distfiles >>>>>> 2) I did a make clean makesum stage (which ran fine) >>>>>> 3) I did a make clean package (which always runs into the >>>>>> following error: =3D> Attempting to fetch >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No such >>>>>> file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz: >>>>>> size unknown fetch: >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz: >>>>>> size of remote file is not known etcd-io-etcd-v3.5.0_GH0.tar.gz >>>>>> 3925 kB 10 MBps 00s =3D> Attempting to >>>>>> fetch >>>>>> = http://distcache.FreeBSD.org/ports-distfiles/etcd-io-etcd-v3.5.0_GH0.tar.g= z >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No such >>>>>> file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No >>>>>> such file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No >>>>>> such file or directory fetch: 4020010: No such file or directory >>>>>> fetch: >>>>>> = http://distcache.FreeBSD.org/ports-distfiles/etcd-io-etcd-v3.5.0_GH0.tar.g= z: >>>>>> Not Found =3D> Couldn't fetch it - please try to retrieve this =3D>= >>>>>> port manually into /usr/ports/distfiles/ and try again. *** >>>>>> Error code 1 >>>>>>=20 >>>>>> Is there anything I did wrong? Anything I can do to fix this >>>>>> issue?=20 >>>>>=20 >>>>> Unless someone else knows what=E2=80=99s wrong anyway: Could you = share >>>>> your port skeleton? (at least the files that changed or the >>>>> output of `git diff=E2=80=99) >>>>>=20 >>>>>=20 >>>>>> Thanks in advance >>>>>> Markus =20 >>>>=20 >>>=20 >>> distinfo contains the entry for etcd-io-etcd-v3.5.0_GH0.tar.gz >>> multiple times (due to it being listed multiple times in GH_TUPLE). >>>=20 >>> It seems to build okay when getting rid of the duplicates in >>> distinfo. I don't know if what you're doing is officially >>> supported, but if it is, we should probably adapt tooling. Also, >>> portlint didn't complain and `make makesum' re-creates the >>> duplicates. >>>=20 >>> @portmgr Please find attached an example of a patch that dedups >>> distinfo on `make makesum', it might more sense to fix this >>> somewhere else in the framework (so that e.g., checksums aren't >>> validated multiple times etc.), up to you. =20 >>=20 >> Ok, then this is one more thing I should take care of! I did not add >> it multiple times on purpose. The GH_TUPLE was just built with go mod >> vendor and modules2tuple. Could it be that there the duplicates need >> to be fixed? >=20 > Well, it seems like they are unpacked in multiple places. I don't know > the software well enough if this is required or not. If it is, you > could leave things as they are now and modify distinfo manually (if = this > is actually allowed by the framework). >=20 > It would be nicer though to create a post-extract target that moves > things into place explicitly (either by copying them, or simply by > creating symbolic links, if this is supported by the software you're > porting). Ok, I will for now remove it manually from the distinfo file. I=E2=80=99m not sure whether it is supported and whether it is worth the = effort, but will have a look at it later and try to understand what = you=E2=80=99re suggesting. Thanks for your quick help! Markus >=20 > -m >=20 >>=20 >>=20 >>>=20 >>> Cheers, >>> Michael >>>=20 >>> --=20 >>> Michael Gmelin >>> <makesum_dedup.diff> =20 >=20 >=20 >=20 > --=20 > Michael Gmelin --Apple-Mail=_079AEBE3-A4CE-4D3E-B31A-CC4945E41DE7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?993AB7FE-D206-49E6-B432-3431017D40DD>