Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 27 Jun 2011 19:19:08 -0500
From:      Zhihao Yuan <lichray@gmail.com>
To:        bug-followup@FreeBSD.org, lichray@gmail.com, riggs@rrr.de,  freebsd-multimedia@freebsd.org
Subject:   Re: ports/156747: multimedia/mplayer: fix 24-bits OSS some improvements
Message-ID:  <BANLkTinc=fDtxzC9PiWGcDV85Y6uYcCzVQ@mail.gmail.com>
next in thread | raw e-mail | index | archive | help 

[-- Attachment #1 --]
I hate the stupid GNATS... Let me deletes all my signatures.

The mplayer is updated to rev_2, so let me bump the revision of my patch.

[-- Attachment #2 --]
diff -ruN --exclude=CVS /usr/ports/multimedia/mplayer.orig/Makefile /usr/ports/multimedia/mplayer/Makefile
--- /usr/ports/multimedia/mplayer.orig/Makefile	2011-06-26 00:07:09.000000000 -0500
+++ /usr/ports/multimedia/mplayer/Makefile	2011-06-27 11:49:57.450755232 -0500
@@ -7,7 +7,7 @@
 
 PORTNAME=	mplayer
 PORTVERSION=	${MPLAYER_PORT_VERSION}
-PORTREVISION=	2
+PORTREVISION=	3
 COMMENT=	High performance media player supporting many formats
 
 .include "${.CURDIR}/Makefile.shared"
@@ -89,6 +89,7 @@
 			--disable-libdirac-lavc \
 			--disable-mencoder \
 			--disable-mpg123 \
+			--disable-alsa \
 			--disable-musepack
 
 .include "${.CURDIR}/Makefile.options"
@@ -272,9 +273,13 @@
 		${WRKSRC}/config.mak
 	@${REINPLACE_CMD} \
 		-e 's#HAVE_FAST_CMOV 1#HAVE_FAST_CMOV 0#g' \
+		${WRKSRC}/config.h
+.if ${OSVERSION} < 802502 || (${OSVERSION} >= 900000 && ${OSVERSION} < 900027)
+	@${REINPLACE_CMD} \
 		-e 's#HAVE_LOG2 1#HAVE_LOG2 0#g' \
 		-e 's#HAVE_LOG2F 1#HAVE_LOG2F 0#g' \
 		${WRKSRC}/config.h
+.endif
 
 post-install:
 	@${MKDIR} ${DATADIR}
diff -ruN --exclude=CVS /usr/ports/multimedia/mplayer.orig/files/patch-libao2-ao_oss.c /usr/ports/multimedia/mplayer/files/patch-libao2-ao_oss.c
--- /usr/ports/multimedia/mplayer.orig/files/patch-libao2-ao_oss.c	2010-04-21 08:07:22.000000000 -0500
+++ /usr/ports/multimedia/mplayer/files/patch-libao2-ao_oss.c	2011-06-27 11:48:27.238467607 -0500
@@ -1,14 +1,38 @@
---- libao2/ao_oss.c.orig	2009-05-12 21:58:57.000000000 -0500
-+++ libao2/ao_oss.c	2009-07-23 19:58:44.870097203 -0500
-@@ -453,6 +453,7 @@
+--- libao2/ao_oss.c.orig	2010-01-11 14:27:52.000000000 -0600
++++ libao2/ao_oss.c	2011-05-01 03:24:37.465580362 -0500
+@@ -72,6 +72,11 @@ static int format2oss(int format)
+     case AF_FORMAT_S16_BE: return AFMT_S16_BE;
+ #ifdef AFMT_S24_PACKED
+     case AF_FORMAT_S24_LE: return AFMT_S24_PACKED;
++#elif defined(__FreeBSD__) && defined(AFMT_S24_LE)
++    case AF_FORMAT_U24_LE: return AFMT_U24_LE;
++    case AF_FORMAT_U24_BE: return AFMT_U24_BE;
++    case AF_FORMAT_S24_LE: return AFMT_S24_LE;
++    case AF_FORMAT_S24_BE: return AFMT_S24_BE;
+ #endif
+ #ifdef AFMT_U32_LE
+     case AF_FORMAT_U32_LE: return AFMT_U32_LE;
+@@ -115,6 +120,11 @@ static int oss2format(int format)
+     case AFMT_S16_BE: return AF_FORMAT_S16_BE;
+ #ifdef AFMT_S24_PACKED
+     case AFMT_S24_PACKED: return AF_FORMAT_S24_LE;
++#elif defined(__FreeBSD__) && defined(AFMT_S24_LE)
++    case AFMT_U24_LE: return AF_FORMAT_U24_LE;
++    case AFMT_U24_BE: return AF_FORMAT_U24_BE;
++    case AFMT_S24_LE: return AF_FORMAT_S24_LE;
++    case AFMT_S24_BE: return AF_FORMAT_S24_BE;
+ #endif
+ #ifdef AFMT_U32_LE
+     case AFMT_U32_LE: return AF_FORMAT_U32_LE;
+@@ -448,6 +458,7 @@ static void reset(void){
    fcntl(audio_fd, F_SETFD, FD_CLOEXEC);
  #endif
  
 +  ioctl (audio_fd, SNDCTL_DSP_SPEED, &ao_data.samplerate);
    oss_format = format2oss(ao_data.format);
-   if(ao_data.format == AF_FORMAT_AC3)
+   if(AF_FORMAT_IS_AC3(ao_data.format))
      ioctl (audio_fd, SNDCTL_DSP_SPEED, &ao_data.samplerate);
-@@ -464,7 +465,6 @@
+@@ -459,7 +470,6 @@ static void reset(void){
        int c = ao_data.channels-1;
        ioctl (audio_fd, SNDCTL_DSP_STEREO, &c);
      }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinc=fDtxzC9PiWGcDV85Y6uYcCzVQ>