Date: Mon, 11 Mar 2013 09:39:59 +0100 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, Konstantin Belousov <kostikbel@gmail.com>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r248060 - in head/sys/dev/drm2: . ttm Message-ID: <513D985F.40902@FreeBSD.org> In-Reply-To: <CAF6rxgka6kg9raW-v4iQ5WY80d0eQg0Lg87pCFqeQTGUdJ7W=g@mail.gmail.com> References: <201303081811.r28IB2JI009017@svn.freebsd.org> <CAF6rxgka6kg9raW-v4iQ5WY80d0eQg0Lg87pCFqeQTGUdJ7W=g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi Eitan!
On 08.03.2013 19:14, Eitan Adler wrote:
> On 8 March 2013 13:11, Jean-Sebastien Pedron <dumbbell@freebsd.org> wrote:
>> @@ -125,8 +125,6 @@ static ssize_t ttm_mem_zone_store(struct
>>
>> static void ttm_mem_global_kobj_release(struct ttm_mem_global *glob)
>> {
>> -
>> - free(glob, M_TTM_ZONE);
>> }
>
> Can this function now be removed, because it appears to be empty?
I guess we could get rid of the reference counting too, because we
already have a refcount in the struct drm_global_reference containing
struct ttm_mem_global or struct ttm_bo_global. This needs further
investigation though.
Konstantin, what do you think about this?
--
Jean-Sébastien Pédron
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlE9mGUACgkQa+xGJsFYOlMQdgCfSDT94mj0xVoRz4DSDxa8Byfw
qXEAn1wZFDZ486F62rLnH7X5omK276Nz
=9sWL
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?513D985F.40902>