Date: Thu, 6 Apr 2017 12:41:02 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs Message-ID: <06998a2b-fa92-500a-cdf6-5057ca96a76f@FreeBSD.org> In-Reply-To: <201704061817.v36IHT8i088712@repo.freebsd.org> References: <201704061817.v36IHT8i088712@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d6QmR7mJ6tHhjmR3RPEp7N85JoQLfaJBR Content-Type: multipart/mixed; boundary="J5KuqnVMLX3XGdgo1lAW4lpPBsl6jhsES"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <06998a2b-fa92-500a-cdf6-5057ca96a76f@FreeBSD.org> Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs References: <201704061817.v36IHT8i088712@repo.freebsd.org> In-Reply-To: <201704061817.v36IHT8i088712@repo.freebsd.org> --J5KuqnVMLX3XGdgo1lAW4lpPBsl6jhsES Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/6/2017 11:17 AM, Toomas Soome wrote: > Author: tsoome > Date: Thu Apr 6 18:17:29 2017 > New Revision: 316585 > URL: https://svnweb.freebsd.org/changeset/base/316585 >=20 > Log: > loader: zfs reader should check all labels > =20 > The current zfs reader is only checking first label from each device,= however, > we do have 4 labels on device and we should check all 4 to be protect= ed > against disk failures and incomplete label updates. > =20 > The difficulty is about the fact that 2 label copies are in front of = the > pool data, and 2 are at the end, which means, we have to know the siz= e of > the pool data area. > =20 > Since we have now the mechanism from common/disk.c to use the partiti= on > information, it does help us in this task; however, there are still s= ome > corner cases. > =20 > Namely, if the pool is created without partition, directly on the dis= k, > and firmware will give us the wrong size for the disk, we only can ch= eck > the first two label copies. > =20 > Reviewed by: allanjude > Differential Revision: https://reviews.freebsd.org/D10203 Something seems wrong in make universe: > cc -isystem /usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/include -= L/usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/lib -B/usr/obj/sparc64= =2Esparc64/root/git/freebsd/tmp/usr/lib --sysroot=3D/usr/obj/sparc64.spar= c64/root/git/freebsd/tmp -B/usr/obj/sparc64.sparc64/root/git/freebsd/tmp/= usr/bin -O2 -pipe -DLOADER_DISK_SUPPORT -DLOADER_UFS_SUPPORT -DLOADER_CD9= 660_SUPPORT -DLOADER_ZFS_SUPPORT -I/root/git/freebsd/sys/boot/sparc64/zfs= loader/../../zfs -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../../= cddl/boot/zfs -DLOADER_GZIP_SUPPORT -DLOADER_NET_SUPPORT -DLOADER_NFS_SUP= PORT -DLOADER_TFTP_SUPPORT -DBOOT_FORTH -I/root/git/freebsd/sys/boot/spar= c64/zfsloader/../../ficl -I/root/git/freebsd/sys/boot/sparc64/zfsloader/.= =2E/../ficl/sparc64 -DLOADER_DISK_SUPPORT -DLOADER_GPT_SUPPORT -DLOADER_M= BR_SUPPORT -DLOADER_GELI_SUPPORT -I/root/git/freebsd/sys/boot/ficl -I/roo= t/git/freebsd/sys/boot/ficl/sparc64 -I/root/git/freebsd/sys/boot/ficl/../= common -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../common -I. -I= /root/git/freebsd/sys/boot/sparc64/zfsloader/../../ofw/libofw/ -I/root/gi= t/freebsd/sys/boot/sparc64/zfsloader/../../../../lib/libstand/ -I/root/gi= t/freebsd/sys -ffreestanding -std=3Dgnu99 -static -nostdlib -o zfsloader = locore.o main.o metadata.o vers.o boot.o commands.o console.o devopen.o i= nterp.o interp_backslash.o interp_parse.o ls.o misc.o module.o panic.o lo= ad_elf64.o reloc_elf64.o dev_net.o disk.o part.o crc32.o interp_forth.o = /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/../.= =2E/ficl/libficl.a /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/spa= rc64/zfsloader/../../zfs/libzfsboot.a /usr/obj/sparc64.sparc64/root/git/f= reebsd/sys/boot/sparc64/zfsloader/../../ofw/libofw/libofw.a -lstand > --- zfsloader --- > /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/..= /../zfs/libzfsboot.a(zfs.o): In function `zfs_probe': > zfs.c:(.text+0x7f28): undefined reference to `ldi_get_size' > *** [zfsloader] Error code 1 --=20 Regards, Bryan Drewery --J5KuqnVMLX3XGdgo1lAW4lpPBsl6jhsES-- --d6QmR7mJ6tHhjmR3RPEp7N85JoQLfaJBR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJY5pnSAAoJEDXXcbtuRpfP8NgH/A/muY76/C6fXD4LKvQvzMIV ufjgUI9ZiG17YSJciL/+6Vub4fheXQPZz1kT2sYwR2G7a1jYJecQG4y2LhjzD+Bs fGbmFRym2fomIQ3yZ0NJAeWWzcVlIx2yeSs2hhOmNvYEW594YH/TzO5be2COL8tL Vy3RtmGw0yOIf3z01ZheTQCrJUjHu5BnemHa3DR8KvE+GU77hOLAbktmj3yAaxnS C+cz9WT4FbJW4iqw+wf09Tr0Bi0pihecJdqaP3v7Czo1wM3cz3vn5cky/rbp0ZCI UXAOH24XBNum8QpsWGlKyjIeyrVSznSVrjREQieZXS2ukPIbQ9fHg/kRnNftIug= =2GwO -----END PGP SIGNATURE----- --d6QmR7mJ6tHhjmR3RPEp7N85JoQLfaJBR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06998a2b-fa92-500a-cdf6-5057ca96a76f>