Date: Wed, 23 May 2012 00:01:29 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: "mdf@FreeBSD.org" <mdf@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "David E. O'Brien" <obrien@freebsd.org>, BruceEvans <brde@optusnet.com.au>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r235797 - head/contrib/gcc Message-ID: <E8EA81ED-EA81-4ED3-9973-9DE1C2F26C53@gmail.com> In-Reply-To: <4FBC86B3.8020105@FreeBSD.org> References: <201205221818.q4MII7lk019626@svn.freebsd.org> <20120523050739.H3621@besplex.bde.org> <CAMBSHm-C7YdU0uPa7aJ6FxDWhZzQiD0_uTj=f1nhV2k5SZ5%2B_A@mail.gmail.com> <4FBC86B3.8020105@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 22, 2012, at 11:41 PM, Dimitry Andric <dim@FreeBSD.org> wrote: > On 2012-05-22 23:07, mdf@FreeBSD.org wrote: > ... >> We run with the following at Isilon, which is somewhat bogus because >> it allows a bit of sloppiness in types, but is also terribly >> convenient since it means no casting on printf arguments is needed: >=20 > Please don't. If you want to write portable code, use the (admittedly > horrible) PRId64 macros instead. Agreed, because the patch attached earlier disguises issues with signedness (= for one) and I've seen some interesting bugs creep in because of issues like= that, an it's painful cleaning up those problems later on (esp. considering= that clang will replace gcc not too far down the line)... Thanks, -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8EA81ED-EA81-4ED3-9973-9DE1C2F26C53>