Date: Thu, 29 Sep 2011 15:20:04 -0700 From: Craig Rodrigues <rodrigc@crodrigues.org> To: Jaakko Heinonen <jh@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0 Message-ID: <CAG=rPVcLUqs14VfxKffDBWCoBG7u=C5dV45n3ameRXzu5rqHvQ@mail.gmail.com> In-Reply-To: <20110928081514.GA5077@jh> References: <4E811FF7.7010607@a1poweruser.com> <4E8126D3.5020407@FreeBSD.org> <CAG=rPVeAPt0_=jNXaHcnB8QCtYuvi5z69MDMFEgyD0HBQT0Mcw@mail.gmail.com> <4E812DB7.3000302@FreeBSD.org> <CAG=rPVcTHiPLFG1%2BdZmi1OWpyZsw=Px=PJT55UFGN_mxt3y%2BJw@mail.gmail.com> <alpine.BSF.2.00.1109262027460.81576@toaster.local> <CAG=rPVeYjqZJuEzVG_kf%2B29bZx%2BZ%2B7du6DsoFou92WDx78B5Dg@mail.gmail.com> <alpine.BSF.2.00.1109262106390.81576@toaster.local> <CAJ-VmokTFaG09=3S8Fw1RwYDJ-Q2OXd0rox6e5AW1DBR4W1AjA@mail.gmail.com> <CAG=rPVdhqhjPEwHGhHBoOYB6rTX=UD2%2B-ehK8-6oT93M5Ec5Tg@mail.gmail.com> <20110928081514.GA5077@jh>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015175889d60e33cb04ae1be964 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen <jh@freebsd.org> wrote: > > I think that using the FEATURE() macro and feature_present(3) might be > more appropriate for this. > > Thanks. > -- > Jaakko > Oh, OK. I was unfamiliar with these API's because they are new in FreeBSD 8. :) How about the attached patch? -- Craig Rodrigues rodrigc@crodrigues.org --0015175889d60e33cb04ae1be964 Content-Type: text/plain; charset=US-ASCII; name="ata_cam_patch.txt" Content-Disposition: attachment; filename="ata_cam_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt6b3uz50 SW5kZXg6IHN5cy9kZXYvYXRhL2F0YS1hbGwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvZGV2L2F0YS9h dGEtYWxsLmMJKHJldmlzaW9uIDIyNTM2OCkKKysrIHN5cy9kZXYvYXRhL2F0YS1hbGwuYwkod29y a2luZyBjb3B5KQpAQCAtMTIwLDYgKzEyMCw5IEBACiBUVU5BQkxFX0lOVCgiaHcuYXRhLnNldG1h eCIsICZhdGFfc2V0bWF4KTsKIFNZU0NUTF9JTlQoX2h3X2F0YSwgT0lEX0FVVE8sIHNldG1heCwg Q1RMRkxBR19SRFRVTiwgJmF0YV9zZXRtYXgsIDAsCiAJICAgIkFUQSBkaXNrIHNldCBtYXggbmF0 aXZlIGFkZHJlc3MiKTsKKyNpZmRlZiBBVEFfQ0FNCitGRUFUVVJFKGF0YV9jYW0sICJBVEEgZGV2 aWNlcyBhcmUgYWNjZXNzZWQgdGhyb3VnaCB0aGUgY2FtKDQpIGRyaXZlciIpOworI2VuZGlmCiAK IC8qCiAgKiBuZXdidXMgZGV2aWNlIGludGVyZmFjZSByZWxhdGVkIGZ1bmN0aW9ucwpJbmRleDog dXNyLnNiaW4vYnVybmNkL2J1cm5jZC44Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHVzci5zYmluL2J1cm5jZC9i dXJuY2QuOAkocmV2aXNpb24gMjI1MzY4KQorKysgdXNyLnNiaW4vYnVybmNkL2J1cm5jZC44CSh3 b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMywxMyBAQAogLlNoIE5BTUUKIC5ObSBidXJuY2QKIC5O ZCBjb250cm9sIHRoZSBBVEFQSSBDRC1SL1JXIGRyaXZlcgorLlBwCitUaGlzIHV0aWxpdHkgd2Fz CisuRW0gZGVwcmVjYXRlZAoraW4KKy5GeCA5LjAgLgorU2VlCisuU3ggTk9URVMgLgogLlNoIFNZ Tk9QU0lTCiAuTm0KIC5PcCBGbCBkZUZsbW5wcXR2CkBAIC0yMTEsNiArMjE4LDEwIEBACiAuTm0K IHV0aWxpdHkgYXBwZWFyZWQgaW4KIC5GeCA0LjAgLgorLlBwCisuTm0KK3dhcyBkZXByZWNhdGVk IGluCisuRnggOS4wIC4KIC5TaCBBVVRIT1JTCiBUaGUKIC5ObQpAQCAtMjIwLDMgKzIzMSwxOSBA QAogLkFxIHNvc0BGcmVlQlNELm9yZyAuCiAuU2ggQlVHUwogUHJvYmFibHksIHBsZWFzZSByZXBv cnQgd2hlbiBmb3VuZC4KKy5TaCBOT1RFUworV2hlbgorLkJkIC1yYWdnZWQgLW9mZnNldCBpbmRl bnQKKy5DZCAib3B0aW9ucyBBVEFfQ0FNIgorLkVkCisuUHAKK2lzIGNvbXBpbGVkIGludG8gdGhl IGtlcm5lbCwgdGhlbgorLlhyIGNkcmVjb3JkIDEgLAorYXZhaWxhYmxlIGluIHRoZQorLkZ4CitQ b3J0cyBDb2xsZWN0aW9uIGFzIHBhcnQgb2YgdGhlCisuUGEgc3lzdXRpbHMvY2RydG9vbHMKK3Bv cnQsIG11c3QgYmUgdXNlZCBpbnN0ZWFkLgorUmVmZXIgdG86CisuUHAKK2h0dHA6Ly93d3cuZnJl ZWJzZC5vcmcvZG9jL2hhbmRib29rL2NyZWF0aW5nLWNkcy5odG1sI0NEUkVDT1JECkluZGV4OiB1 c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdXNyLnNiaW4vYnVybmNkL2J1 cm5jZC5jCShyZXZpc2lvbiAyMjUzNjgpCisrKyB1c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMJKHdv cmtpbmcgY29weSkKQEAgLTgyLDYgKzgyLDE1IEBACiAJaW50IGJsb2NrX3NpemUgPSAwLCBibG9j a190eXBlID0gMCwgY2RvcGVuID0gMCwgZHZkcncgPSAwOwogCWNvbnN0IGNoYXIgKmRldiwgKmVu dl9zcGVlZDsKIAorCWlmIChmZWF0dXJlX3ByZXNlbnQoImF0YV9jYW0iKSkgeworCQlwcmludGYo IlxuQVRBX0NBTSBvcHRpb24gaXMgZW5hYmxlZCBpbiBrZXJuZWwuXG4iCisJCSAgICAiSW5zdGFs bCB0aGUgc3lzdXRpbHMvY2RydG9vbHMgcG9ydCBhbmQgdXNlIGNkcmVjb3JkICIKKwkJICAgICJp bnN0ZWFkLlxuXG4iCisJCSAgICAiUGxlYXNlIHJlZmVyIHRvOlxuIgorCQkgICAgImh0dHA6Ly93 d3cuZnJlZWJzZC5vcmcvZG9jL2hhbmRib29rL2NyZWF0aW5nLWNkcy5odG1sI0NEUkVDT1JEXG4i KTsKKwkJZXhpdCgxKTsKKwl9CisKIAlpZiAoKGRldiA9IGdldGVudigiQ0RST00iKSkgPT0gTlVM TCkKIAkJZGV2ID0gIi9kZXYvYWNkMCI7CiAKSW5kZXg6IHNiaW4vYXRhY29udHJvbC9hdGFjb250 cm9sLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuYwkocmV2aXNp b24gMjI1MzY4KQorKysgc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuYwkod29ya2luZyBjb3B5 KQpAQCAtMzc4LDYgKzM3OCwxMSBAQAogewogCWludCBmZCwgbW9kZSwgY2hhbm5lbCwgYXJyYXk7 CiAKKwlpZiAoZmVhdHVyZV9wcmVzZW50KCJhdGFfY2FtIikpIHsKKwkJZXJyeCgxLCAiQVRBX0NB TSBvcHRpb24gaXMgZW5hYmxlZCBpbiBrZXJuZWwuXG4iCisJCSAgICAiUGxlYXNlIHVzZSBjYW1j b250cm9sIGluc3RlYWQuXG4iKTsKKwl9CisKIAlpZiAoYXJnYyA8IDIpCiAJCXVzYWdlKCk7CiAK SW5kZXg6IHNiaW4vYXRhY29udHJvbC9hdGFjb250cm9sLjgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2Jpbi9h dGFjb250cm9sL2F0YWNvbnRyb2wuOAkocmV2aXNpb24gMjI1MzY4KQorKysgc2Jpbi9hdGFjb250 cm9sL2F0YWNvbnRyb2wuOAkod29ya2luZyBjb3B5KQpAQCAtMjUsMTIgKzI1LDE5IEBACiAuXCIK IC5cIiAkRnJlZUJTRCQKIC5cIgotLkRkIEZlYnJ1YXJ5IDIxLCAyMDA5CisuRGQgU2VwdGVtYmVy IDI3LCAyMDExCiAuRHQgQVRBQ09OVFJPTCA4CiAuT3MKIC5TaCBOQU1FCiAuTm0gYXRhY29udHJv bAogLk5kIEFUQSBkZXZpY2UgZHJpdmVyIGNvbnRyb2wgcHJvZ3JhbQorLlBwCitUaGlzIHV0aWxp dHkgd2FzCisuRW0gZGVwcmVjYXRlZAoraW4KKy5GeCA5LjAgLgorU2VlCisuU3ggTk9URVMgLgog LlNoIFNZTk9QU0lTCiAuTm0KIC5BcSBBciBjb21tYW5kCkBAIC0zNjEsMTEgKzM2OCwxNyBAQAog dXAgYWxsIHRoZSB0aW1lLgogLlNoIFNFRSBBTFNPCiAuWHIgYXRhIDQKKy5YciBjYW0gNAorLlhy IGNhbWNvbnRyb2wgOAogLlNoIEhJU1RPUlkKIFRoZQogLk5tCiB1dGlsaXR5IGZpcnN0IGFwcGVh cmVkIGluCiAuRnggNC42IC4KKy5QcAorLk5tCit3YXMgZGVwcmVjYXRlZCBpbgorLkZ4IDkuMCAu CiAuU2ggQVVUSE9SUwogLkFuIC1ub3NwbGl0CiBUaGUKQEAgLTM3NywzICszOTAsMTYgQEAKIFRo aXMgbWFudWFsIHBhZ2Ugd2FzIHdyaXR0ZW4gYnkKIC5BbiBTXCgvb3JlbiBTY2htaWR0CiAuQXEg c29zQEZyZWVCU0Qub3JnIC4KKy5TaCBOT1RFUworVGhlCisuTm0KK3V0aWxpdHkgd2FzIGRlcHJl Y2F0ZWQgaW4KKy5GeCA5LjAgLgorV2hlbgorLkJkIC1yYWdnZWQgLW9mZnNldCBpbmRlbnQKKy5D ZCAib3B0aW9ucyBBVEFfQ0FNIgorLkVkCisuUHAKK2lzIGNvbXBpbGVkIGludG8gdGhlIGtlcm5l bCwgdGhlbgorLlhyIGNhbWNvbnRyb2wgOAorbXVzdCBiZSB1c2VkIGluc3RlYWQuCg== --0015175889d60e33cb04ae1be964--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVcLUqs14VfxKffDBWCoBG7u=C5dV45n3ameRXzu5rqHvQ>