Date: Tue, 5 Oct 2021 18:27:15 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fb5f03a87cf4 - main - Mk/bsd.lto.mk: add global LTO support for ports Message-ID: <YVx84wGVlSr2nmBX@KGPE-D16> In-Reply-To: <20211004133056.z7e2iyrhlwprvvvp@aching.in.mat.cc> References: <202109301834.18UIYKrL013410@gitrepo.freebsd.org> <20211004133056.z7e2iyrhlwprvvvp@aching.in.mat.cc>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 21-10-04 15:30:56, Mathieu Arnold wrote: > On Thu, Sep 30, 2021 at 06:34:20PM +0000, Piotr Kubaj wrote: > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > > > commit fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > AuthorDate: 2021-09-30 18:27:50 +0000 > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > CommitDate: 2021-09-30 18:27:50 +0000 > > > > Mk/bsd.lto.mk: add global LTO support for ports > > > > It's well known that LTO provides both performance and size benefits for > > binaries. > > > > Add preliminary, opt-in support for global LTO enforcement to ports. Ports that > > provide LTO option on their own and the ones that don't work with LTO will need > > to set LTO_UNSAFE in the future. > > > > PR: 258536 > > Not to be picky about approval and all, but this was added to the > framework, and the framework is maintained by portmgr. When you want to > add something to it, you must consult with portmgr before anything gets > committed. > > In that case, we would have told you not to do it this way, but to make > this a Mk/Uses/lto.mk. > > So please, turn this into a USES=lto. I did consult, but no one replied. IMO adding it to USES is not a good idea, since USES are supposed to be used per port and my idea was to force LTO for all ports, same way that SSP already does. > > > --- > > Mk/bsd.lto.mk | 10 ++++++++++ > > Mk/bsd.port.mk | 4 ++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/Mk/bsd.lto.mk b/Mk/bsd.lto.mk > > new file mode 100644 > > index 000000000000..c2a079ea28bb > > --- /dev/null > > +++ b/Mk/bsd.lto.mk > > @@ -0,0 +1,10 @@ > > +# LTO Support > > + > > +LTO_Include_MAINTAINER= pkubaj@FreeBSD.org > > + > > +.if !defined(LTO_UNSAFE) > > +# Overridable as a user may want to use -flto > > +LTO_CFLAGS?= -flto=thin > > +CFLAGS+= ${LTO_CFLAGS} > > +CXXFLAGS+= ${LTO_CFLAGS} > > +.endif > > diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk > > index 337d3f6be6a6..493b15a59fff 100644 > > --- a/Mk/bsd.port.mk > > +++ b/Mk/bsd.port.mk > > @@ -1799,6 +1799,10 @@ INSTALL_TARGET:= ${INSTALL_TARGET:S/^install-strip$/install/g} > > .endif > > .endif > > > > +.if defined(USE_LTO) > > +.include "${PORTSDIR}/Mk/bsd.lto.mk" > > +.endif > > + > > .if !defined(WITHOUT_SSP) > > .include "${PORTSDIR}/Mk/bsd.ssp.mk" > > .endif > > > > -- > Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFcfOMACgkQelmbhSCD nJ2CKQ//XNcrghMilYBZczVgzxQG1nszGAHJu6QzxwEy328brKSjSlprpLwPr4fq WMCPvqhovKdiVYkQq5zjEA7/lnbYxhIzya2N6iw0vpplvBRv55H4n/dUGtErwZXx mFxd4ob7ytvVp4Pf81JsbdFtZcpFCxLXDSbLD7xpjMULc9h7k86ZC6whmD5p/X7D An6ttMieM7gg2SBV2czJtzG8FR9LxS4QH7kruVs3scodQRVuqvrZrwejVIpt+b1d eaL8jIRDn6SowoMkwJ1Gtjsuc6uESwWmz8avFpmLq3W6ZeMjGq8yLal/M7elN06v aTeAX0VUy01aSDwri8iLkAbj9Eu4ia0NsmZgV29MvBHwt1SXZgVr4OTZYRp2oCC0 WOOH794U9qTUm2EHgPBr8+WxoqBM35Zfavcl5yJb4wtJetk3dMdLU4W732hxlX/K IzEw8CB4h2BKNQ79eUMmHSDttyO6nxH9PKQACmhJcamtnWNX4uicKPGS0mUlkC82 UJcecGfhdPnpe3/4Dqb4+Vqnl7u0eqtZ+FRb6EMTSIPw7DyubUeOUU6kH6sFhwxL db7op9e0swY3atBpLP31fq4QFbyXuK1VOwp6KiKGpUqD+D4Wuvevo9jHcdNFlRqj 4/72hYf7nBdt3Sw8nCn/+JrKjfCTzGZu5caTO59FqcpRK93CkZs= =1a60 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVx84wGVlSr2nmBX>