Date: Wed, 28 Jan 2009 15:33:05 -0500 From: John Baldwin <jhb@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187838 - head/sys/fs/cd9660 Message-ID: <200901281533.06173.jhb@freebsd.org> In-Reply-To: <20090128203053.GJ2009@deviant.kiev.zoral.com.ua> References: <200901281854.n0SIsvNX029332@svn.freebsd.org> <20090128203053.GJ2009@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 28 January 2009 3:30:55 pm Kostik Belousov wrote: > On Wed, Jan 28, 2009 at 06:54:57PM +0000, John Baldwin wrote: > > Author: jhb > > Date: Wed Jan 28 18:54:56 2009 > > New Revision: 187838 > > URL: http://svn.freebsd.org/changeset/base/187838 > ... > > - Use an inlined version of vn_vget_ino() to handle races with .. > > lookups. I had to inline the code here since cd9660 uses an internal > > vget routine to save a disk I/O that would otherwise re-read the > > directory block. > > Hmm, also please see the ffs_softdep.c:softdep_fsync(), that also > needs the similar fix and cannot be converted to vn_vget_ino() due to > ffs_vgetf(). > > I was unable to propose some useful generalization of vn_vget_ino() > so far. Maybe it would be possible to have subroutines for the before and after bits that go around the vget() (That could be ugly though)? For my udf patches I was able to use vn_vget_ino() which was nice. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901281533.06173.jhb>