Date: Tue, 27 Jun 2000 20:11:32 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Doug Rabson <dfr@nlsystems.com> Cc: Warner Losh <imp@village.org>, new-bus@FreeBSD.ORG Subject: Re: Why can't I have.. Message-ID: <Pine.BSF.4.21.0006272006460.6062-100000@besplex.bde.org> In-Reply-To: <Pine.BSF.4.21.0006270715420.28246-100000@salmon.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jun 2000, Doug Rabson wrote:
> On Mon, 26 Jun 2000, Warner Losh wrote:
>
> >
> > ... a INTR_TYPE_FAST | INTR_TYPE_MISC?
> >
> > It gives me:
> > panic("still using grody create_intr interface");
> >
> > What's the deal? It is easy enough to fix the problem, but I was
> > wondering why the code is still there...
> >
> > This is, admittedly, in -stable.
>
> Hmm. I thought Peter had fixed that ages ago. If you can generate patches,
> I would appreciate it.
I seem to have fixed it locally ages ago.
diff -c2 nexus.c~ nexus.c
*** nexus.c~ Mon Jun 26 17:57:09 2000
--- nexus.c Mon Jun 26 17:57:11 2000
***************
*** 399,403 ****
{
intrmask_t *mask;
- driver_t *driver;
int error, icflags;
--- 411,414 ----
***************
*** 411,423 ****
else
icflags = INTR_EXCL;
!
! driver = device_get_driver(child);
! switch (flags) {
case INTR_TYPE_TTY:
mask = &tty_imask;
- break;
- case (INTR_TYPE_TTY | INTR_TYPE_FAST):
- mask = &tty_imask;
- icflags |= INTR_FAST;
break;
case INTR_TYPE_BIO:
--- 422,430 ----
else
icflags = INTR_EXCL;
! if (flags & INTR_TYPE_FAST)
! icflags |= INTR_FAST;
! switch (flags & ~INTR_TYPE_FAST) {
case INTR_TYPE_TTY:
mask = &tty_imask;
break;
case INTR_TYPE_BIO:
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-new-bus" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0006272006460.6062-100000>