Date: Tue, 23 Jan 2018 15:31:03 +0100 From: Alex Dupre <ale@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files Message-ID: <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org> In-Reply-To: <20180123140938.GA73049@FreeBSD.org> References: <201801231358.w0NDwMa8074241@repo.freebsd.org> <20180123140938.GA73049@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev wrote: > On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote: >> New Revision: 459751 >> URL: https://svnweb.freebsd.org/changeset/ports/459751 >> >> Log: >> The Solidity Contract-Oriented Programming Language >> >> WWW: https://github.com/ethereum/solidity >> >> Added: head/lang/solidity/Makefile >> ... Hi Alexey, I often agree with your comments, but this time I have to strongly disagree. % portlint -tac solidity/ looks fine. >> +COMMENT= Solidity Contract-Oriented Programming Language > > COMMENT= Contract-oriented programming language Come on, then the comment for the scala port should be "Programming Language"? > >> +OPTIONS_DEFINE= SMT >> +SMT_DESC= SMT Checker >> +SMT_LIB_DEPENDS=libz3.so:math/z3 >> + >> +USES= cmake > > Misplaced USES. I don't see what's misplaced here, portlint doesn't seem to agree with you. >> +CMAKE_ARGS+= -DUSE_LD_GOLD=OFF -DTESTS=OFF \ >> + -DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \ >> + -DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib" > > And CMAKE_ARGS (also bogus +=). Really? >> +pre-patch: >> + @${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/ >> + @${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt > > Excessive indentation of target recipe (commands). Seriously? >> Added: head/lang/solidity/pkg-descr >> ... >> @@ -0,0 +1,3 @@ >> +The Solidity Contract-Oriented Programming Language >> + >> +WWW: https://github.com/ethereum/solidity > > Bad port description (verbatim copy of COMMENT), tells nothing about the > port (violation of PHB Section 3.2.1). This is the only thing I agree on, changed. -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57ffd7bd-6a3f-b315-b582-17d9dccee5a8>