Date: Wed, 28 Mar 2018 18:17:03 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Kyle Evans <kevans@freebsd.org> Cc: Allan Jude <allanjude@freebsd.org>, Oliver Pinter <oliver.pinter@hardenedbsd.org>, Eitan Adler <eadler@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi... Message-ID: <201803290117.w2T1H3lt059992@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CACNAnaHWsc7J3L%2BVL7rw0CJO6AP84G75um7GPTDLuhVd7LiMfg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Wed, Mar 28, 2018 at 8:04 PM, Allan Jude <allanjude@freebsd.org> wrote: > > On 2018-03-28 14:15, Oliver Pinter wrote: > >> Hi! > >> > >> This part of the MFC is wrong: > >> > >> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 > >> > >> Could you please MFC back the other random related changes too? Some > >> of them made by cem@. > >> > >> On 3/14/18, Eitan Adler <eadler@freebsd.org> wrote: > >>> Author: eadler > >>> Date: Wed Mar 14 03:19:51 2018 > >>> New Revision: 330897 > >>> URL: https://svnweb.freebsd.org/changeset/base/330897 > >>> > >>> Log: > >>> Partial merge of the SPDX changes > >>> > >>> These changes are incomplete but are making it difficult > >>> to determine what other changes can/should be merged. > >>> > >>> No objections from: pfg > >>> > > Am I missing something? If this MFC was supposed to be of the SPDX > > license tagging, why does it have any functional changes? > > > > Especially changes to random(4)? > > For extra fun, it also had some ARM driver changes that had broken the > VERSATILE kernels, as I recall. gonzo@ took care of MFC'ing the other > parts needed for those, though. It does make me wonder what else was > overlooked, but the commit was large enough that it's not fun to > glance over. I have an audit report coming out in a few minutes that makes it clear what the non SPDX bits are, I belive we can clean this up with a few rXXXXXX reverts in short order. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803290117.w2T1H3lt059992>