Date: Thu, 4 Feb 2016 15:57:19 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294560 - head/etc/rc.d Message-ID: <56B3E55F.3040004@FreeBSD.org> In-Reply-To: <56B3DE8E.9020603@FreeBSD.org> References: <201601221214.u0MCE8Jk054031@repo.freebsd.org> <56B3DE8E.9020603@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2/4/2016 3:28 PM, Bryan Drewery wrote: > On 1/22/2016 4:14 AM, Dag-Erling Smørgrav wrote: >> Author: des >> Date: Fri Jan 22 12:14:08 2016 >> New Revision: 294560 >> URL: https://svnweb.freebsd.org/changeset/base/294560 >> >> Log: >> Do not generate RSA1 or DSA keys by default. >> >> Modified: >> head/etc/rc.d/sshd >> >> Modified: head/etc/rc.d/sshd >> ============================================================================== >> --- head/etc/rc.d/sshd Fri Jan 22 12:00:56 2016 (r294559) >> +++ head/etc/rc.d/sshd Fri Jan 22 12:14:08 2016 (r294560) >> @@ -20,9 +20,9 @@ configtest_cmd="sshd_configtest" >> pidfile="/var/run/${name}.pid" >> extra_commands="configtest keygen reload" >> >> -: ${sshd_rsa1_enable:="yes"} >> +: ${sshd_rsa1_enable:="no"} >> : ${sshd_rsa_enable:="yes"} >> -: ${sshd_dsa_enable:="yes"} >> +: ${sshd_dsa_enable:="no"} >> : ${sshd_ecdsa_enable:="yes"} >> : ${sshd_ed25519_enable:="yes"} >> >> > > I think perhaps you should also remove these as having default paths in > the .c as well and require they be enabled in the config. Otherwise a > warning is given: > > Feb 4 15:25:22 VM sshd[874]: error: Could not load host key: > /etc/ssh/ssh_host_dsa_key This happens on every login even. It's quite annoying. > > Or always generate them but only load them if enabled in the config. > -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWs+VgAAoJEDXXcbtuRpfP5tgIAJ2JsPsm3lvBCrFwE6We1Yun lDkzJMA1TM1k14X0ZLwh5/1wCSmuzqq80ncTAOtTzMlduD80JqWzALdcYXdoJcfO D1VM5+k4VZBriyGFaC2xlb45By6SGgXzXITGNKhyxupDNdsn/Uv9dPgKOkOvc8c0 93RtoRf0JYEGlHJ3Zbchc2zowCY1zh/XmE7FKZYYq/iJ6JF0cVaZ6IWCmFES1tfH PYGZxC91voY5CKxx1F6lO6Zj+PkEW6eI1ervjT3RIUiVfypFpgeFD5npY+QRYlWz fHksuC6sFfVALcNNbISeQ/2FuBLUUDk09EbX8vPJIfylCgcOQ6xDnnDSh28HsWE= =HkAm -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B3E55F.3040004>