Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Oct 2015 14:57:46 +0000 (UTC)
From:      Peter Grehan <grehan@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r288826 - head/usr.sbin/bhyve
Message-ID:  <201510051457.t95EvkvN066415@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: grehan
Date: Mon Oct  5 14:57:45 2015
New Revision: 288826
URL: https://svnweb.freebsd.org/changeset/base/288826

Log:
  Clean up some harmless unimplemented-command warning messages.
  
  - Don't advertize trusted-computing capability in the Identify page.
    This prevents Windows from issuing a TRUSTED_RECEIVE_DMA command.
  - Windows will send down SMART and SECURITY_FREEZE_LOCK
     even though smart and security capabilities were not advertized.
     Send back a silent abort.
  
  Reviewed by:	mav

Modified:
  head/usr.sbin/bhyve/pci_ahci.c

Modified: head/usr.sbin/bhyve/pci_ahci.c
==============================================================================
--- head/usr.sbin/bhyve/pci_ahci.c	Mon Oct  5 13:33:02 2015	(r288825)
+++ head/usr.sbin/bhyve/pci_ahci.c	Mon Oct  5 14:57:45 2015	(r288826)
@@ -926,7 +926,7 @@ handle_identify(struct ahci_port *p, int
 		ata_string((uint8_t *)(buf+23), "001", 8);
 		ata_string((uint8_t *)(buf+27), "BHYVE SATA DISK", 40);
 		buf[47] = (0x8000 | 128);
-		buf[48] = 0x1;
+		buf[48] = 0;
 		buf[49] = (1 << 8 | 1 << 9 | 1 << 11);
 		buf[50] = (1 << 14);
 		buf[53] = (1 << 1 | 1 << 2);
@@ -1683,6 +1683,8 @@ ahci_handle_cmd(struct ahci_port *p, int
 	case ATA_READ_LOG_DMA_EXT:
 		ahci_handle_read_log(p, slot, cfis);
 		break;
+	case ATA_SECURITY_FREEZE_LOCK:
+	case ATA_SMART_CMD:
 	case ATA_NOP:
 		ahci_write_fis_d2h(p, slot, cfis,
 		    (ATA_E_ABORT << 8) | ATA_S_READY | ATA_S_ERROR);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510051457.t95EvkvN066415>