Date: Wed, 15 Nov 2017 13:58:16 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325860 - head/sbin/newfs Message-ID: <CANCZdfrUCnPCwXKj6YZ-uY9zpKh_ObiV1QYRu62vkxriu-5tVw@mail.gmail.com> In-Reply-To: <201711152051.vAFKp6Is052998@pdx.rh.CN85.dnsmgr.net> References: <CANCZdfphPhCXsDkGNtHVkJfYRfZmxqf_sRZPPkCx6akjKER9ag@mail.gmail.com> <201711152051.vAFKp6Is052998@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 15, 2017 1:51 PM, "Rodney W. Grimes" <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: [ Charset UTF-8 unsupported, converting... ] > On Nov 15, 2017 11:47 AM, "Rodney W. Grimes" <freebsd@pdx.rh.cn85.dnsmgr. net> > wrote: > > > Author: emaste > > Date: Wed Nov 15 18:40:40 2017 > > New Revision: 325860 > > URL: https://svnweb.freebsd.org/changeset/base/325860 > > > > Log: > > newfs: warn if newer than kernel > > > > Creating a UFS filesystem with a newfs newer than the running kernel, > > and then mounting that filesystem, can lead to interesting failures. > > > > Add a safety belt to explicitly warn when newfs is newer than the > > running kernel. > > You should probably make the warning if (newer || older) as > either is likely to have interesting side effects, as are > mounting ufs file systems on different versions. > > > Not really. The cg stuff is really only a hassle for the case ed is testing > for. Its too late now, but if you take a newer ufs with the cg stuff in them and mount it on an old system it politly well corrupt the data that the newer kernel needs. So your right, doing this check in newfs wont do anything, but I can tell you this tiny little chain has been a PITA for people that move HD around.... Fsck automatically fixes issues like that. It recomputes the checksums. > *Sigh* why did not UFS grow a version number of its own > when things started to change other than UFS1 vs UFS2. > > > This isn't anything like those changes.. UFS changed in a way that makes it difficult to move UFS drives accross systems that are at differing versions. That IS bad no mater how you slice it. I now have to make sure I fsck a drive when moving it from an old to new system to get the cg checksum stuff fixed. Except it isn't as bad as you say. Warner > Warner > > > Reviewed by: gjb, jhb, mckusick > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D12765 > > > > Modified: > > head/sbin/newfs/newfs.c > > > > Modified: head/sbin/newfs/newfs.c > > ============================================================ > ================== > > --- head/sbin/newfs/newfs.c Wed Nov 15 18:03:31 2017 (r325859) > > +++ head/sbin/newfs/newfs.c Wed Nov 15 18:40:40 2017 (r325860) > > @@ -398,6 +398,10 @@ main(int argc, char *argv[]) > > if (pp != NULL) > > pp->p_size *= secperblk; > > } > > + if (getosreldate() < __FreeBSD_version) { > > + warnx("%s is newer than the running kernel and may not be > compatible", > > + getprogname()); > > + } > > mkfs(pp, special); > > ufs_disk_close(&disk); > > if (!jflag) > > > > > > -- > Rod Grimes > rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrUCnPCwXKj6YZ-uY9zpKh_ObiV1QYRu62vkxriu-5tVw>