Date: Tue, 26 Nov 2013 03:53:39 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, owner-ports-committers@freebsd.org, Erwin Lansing <erwin@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126035339.GA43389@FreeBSD.org> In-Reply-To: <5291C8BD.3070109@marino.st> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote:
> I have attached a diff with the proposed changes covering all three
> ports. It's pretty straight-forward.
>
> .if ${PORT_OPTIONS:MREPLACE_BASE}
> -.if ${OSVERSION} >= 1000500
> +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000500
Given that OSVERSION is used extensively in the tree, I'm worrying that
adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less
readable. Wouldn't it make more sense to place this check somewhere in
single place, and define whatever OSVERSION that looks reasonable when
OPSYS == FreeBSD instead of patching every port?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131126035339.GA43389>