Date: Sat, 10 Sep 2011 14:31:55 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: src-committers@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Robert Watson <rwatson@freebsd.org>, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys Message-ID: <20110910113155.GJ17489@deviant.kiev.zoral.com.ua> In-Reply-To: <28707761-AA24-43D5-AE8B-B0D8842C6F13@lists.zabbadoz.net> References: <201109090744.p897iE9x027234@svn.freebsd.org> <alpine.BSF.2.00.1109101149120.62958@fledge.watson.org> <28707761-AA24-43D5-AE8B-B0D8842C6F13@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--7m2Ta+5QzzfNUVnL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 10, 2011 at 11:21:00AM +0000, Bjoern A. Zeeb wrote: >=20 > On Sep 10, 2011, at 10:54 AM, Robert Watson wrote: >=20 > > On Fri, 9 Sep 2011, Hans Petter Selasky wrote: > >=20 > >> Log: > >> MFC r225350 and r225400: > >>=20 > >> This patch adds automatic detection of USB mass storage devices > >> which does not support the no synchronize cache SCSI command. > >>=20 > >> The __FreeBSD_version version macro has been bumped and > >> external kernel modules needs to be recompiled after > >> this patch. > >>=20 > >> PR: usb/160299 > >=20 > > For most other classes of hardware device driver framework KPIs -- espe= cially things like PCI bus attachment, busdma, CAM, ifnet, and GEOM framewo= rks, our MFC rules would strictly disallow this sort of change, on the grou= nds that it is our KBI policy that we not break common classes of third-par= ty device drivers (i.e., require them to be recompiled). My suspicion is t= hat we should be applying the same rules to the USB framework -- however, I= don't know if we have any third-party USB device drivers? > >=20 > > (If we do, then this change should not have been MFC'd.) >=20 > We do have FreeBSD consumers with private USB drivers, yes. It seems that most of the damage can be mitigated by placing the added fields at the end of the structures, at least for stable/8. --7m2Ta+5QzzfNUVnL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk5rSqoACgkQC3+MBN1Mb4it4wCgp9EuWsJWR3iiFemfYXRCaZqE ULIAnim6ed6WfR5PsJZgPsG4Z75+IQjZ =HOTy -----END PGP SIGNATURE----- --7m2Ta+5QzzfNUVnL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110910113155.GJ17489>