Date: Thu, 5 Jul 2007 13:21:02 GMT From: Oleksandr Tymoshenko <gonzo@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 122949 for review Message-ID: <200707051321.l65DL2pU072714@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=122949 Change 122949 by gonzo@gonzo_jeeves on 2007/07/05 13:20:28 o Enable kdbpeek_X routines family for db_read_bytes. Affected files ... .. //depot/projects/mips2/src/sys/mips/mips/db_interface.c#5 edit Differences ... ==== //depot/projects/mips2/src/sys/mips/mips/db_interface.c#5 (text+ko) ==== @@ -61,19 +61,12 @@ static void kdbpoke_4(db_addr_t addr, int newval); static void kdbpoke_2(db_addr_t addr, short newval); static void kdbpoke_1(db_addr_t addr, char newval); -/* - * XXXMIPS: - */ -#if 0 static short kdbpeek_2(db_addr_t addr); static char kdbpeek_1(db_addr_t addr); +#if 0 static db_addr_t MachEmulateBranch(struct frame *, db_addr_t, unsigned long, int); #endif -/* - * XXXMIPS: - */ -#if 0 int kdbpeek(db_addr_t addr) { @@ -96,7 +89,6 @@ return *(char *)addr; } -#endif /* * kdbpoke -- write a value to a kernel virtual address. @@ -286,18 +278,16 @@ int db_read_bytes(vm_offset_t addr, size_t size, char *data) { - -/* - * XXXMIPS: warning: use of cast expressions as lvalues is deprecated - */ -#if 0 + int *int_ptr = (int *)data; + short *short_ptr = (short *)data; + char *char_ptr = data; while (size >= 4) - *((int*)data)++ = kdbpeek(addr), addr += 4, size -= 4; + *(int_ptr)++ = kdbpeek(addr), addr += 4, size -= 4; while (size >= 2) - *((short*)data)++ = kdbpeek_2(addr), addr += 2, size -= 2; + *(short_ptr)++ = kdbpeek_2(addr), addr += 2, size -= 2; if (size == 1) - *((char*)data)++ = kdbpeek_1(addr); -#endif + *(char_ptr)++ = kdbpeek_1(addr); + return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707051321.l65DL2pU072714>