Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Feb 2014 22:31:46 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r262264 - projects/clang-sparc64/contrib/llvm/lib/Target/Sparc
Message-ID:  <201402202231.s1KMVkjZ090419@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Thu Feb 20 22:31:45 2014
New Revision: 262264
URL: http://svnweb.freebsd.org/changeset/base/262264

Log:
  Pull in r200453 from upstream llvm trunk:
  
    Implement SPARCv9 atomic_swap_64 with a pseudo.
  
    The SWAP instruction only exists in a 32-bit variant, but the 64-bit
    atomic swap can be implemented in terms of CASX, like the other
    atomic rmw primitives.
  
  Submitted by:	rdivacky

Modified:
  projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcISelLowering.cpp
  projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcInstr64Bit.td

Modified: projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcISelLowering.cpp
==============================================================================
--- projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcISelLowering.cpp	Thu Feb 20 22:22:39 2014	(r262263)
+++ projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcISelLowering.cpp	Thu Feb 20 22:31:45 2014	(r262264)
@@ -1499,7 +1499,7 @@ SparcTargetLowering::SparcTargetLowering
 
   if (Subtarget->is64Bit()) {
     setOperationAction(ISD::ATOMIC_CMP_SWAP, MVT::i64, Legal);
-    setOperationAction(ISD::ATOMIC_SWAP, MVT::i64, Expand);
+    setOperationAction(ISD::ATOMIC_SWAP, MVT::i64, Legal);
     setOperationAction(ISD::ATOMIC_LOAD, MVT::i64, Custom);
     setOperationAction(ISD::ATOMIC_STORE, MVT::i64, Custom);
   }
@@ -2886,6 +2886,9 @@ SparcTargetLowering::EmitInstrWithCustom
   case SP::ATOMIC_LOAD_NAND_64:
     return expandAtomicRMW(MI, BB, SP::ANDXrr);
 
+  case SP::ATOMIC_SWAP_64:
+    return expandAtomicRMW(MI, BB, 0);
+
   case SP::ATOMIC_LOAD_MAX_32:
     return expandAtomicRMW(MI, BB, SP::MOVICCrr, SPCC::ICC_G);
   case SP::ATOMIC_LOAD_MAX_64:
@@ -3024,7 +3027,8 @@ SparcTargetLowering::expandAtomicRMW(Mac
 
   // Build the loop block.
   unsigned ValReg = MRI.createVirtualRegister(ValueRC);
-  unsigned UpdReg = MRI.createVirtualRegister(ValueRC);
+  // Opcode == 0 means try to write Rs2Reg directly (ATOMIC_SWAP).
+  unsigned UpdReg = (Opcode ? MRI.createVirtualRegister(ValueRC) : Rs2Reg);
 
   BuildMI(LoopMBB, DL, TII.get(SP::PHI), ValReg)
     .addReg(Val0Reg).addMBB(MBB)
@@ -3036,7 +3040,7 @@ SparcTargetLowering::expandAtomicRMW(Mac
     BuildMI(LoopMBB, DL, TII.get(SP::CMPrr)).addReg(ValReg).addReg(Rs2Reg);
     BuildMI(LoopMBB, DL, TII.get(Opcode), UpdReg)
       .addReg(ValReg).addReg(Rs2Reg).addImm(CondCode);
-  } else {
+  } else if (Opcode) {
     BuildMI(LoopMBB, DL, TII.get(Opcode), UpdReg)
       .addReg(ValReg).addReg(Rs2Reg);
   }

Modified: projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcInstr64Bit.td
==============================================================================
--- projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcInstr64Bit.td	Thu Feb 20 22:22:39 2014	(r262263)
+++ projects/clang-sparc64/contrib/llvm/lib/Target/Sparc/SparcInstr64Bit.td	Thu Feb 20 22:31:45 2014	(r262264)
@@ -463,6 +463,14 @@ defm ATOMIC_LOAD_MAX  : AtomicRMW<atomic
 defm ATOMIC_LOAD_UMIN : AtomicRMW<atomic_load_umin_32, atomic_load_umin_64>;
 defm ATOMIC_LOAD_UMAX : AtomicRMW<atomic_load_umax_32, atomic_load_umax_64>;
 
+// There is no 64-bit variant of SWAP, so use a pseudo.
+let usesCustomInserter = 1, hasCtrlDep = 1, mayLoad = 1, mayStore = 1,
+    Defs = [ICC], Predicates = [Is64Bit] in
+def ATOMIC_SWAP_64 : Pseudo<(outs I64Regs:$rd),
+                            (ins ptr_rc:$addr, I64Regs:$rs2), "",
+                            [(set i64:$rd,
+                                  (atomic_swap_64 iPTR:$addr, i64:$rs2))]>;
+
 // Global addresses, constant pool entries
 let Predicates = [Is64Bit] in {
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402202231.s1KMVkjZ090419>