Date: Fri, 11 Sep 2020 17:00:36 +0000 From: Glen Barber <gjb@freebsd.org> To: Ruslan Garipov <ruslanngaripov@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364891 - in head: . release release/scripts Message-ID: <20200911170036.GD61041@FreeBSD.org> In-Reply-To: <6d1dd875-c0d6-0006-d829-905534728589@gmail.com> References: <202008272119.07RLJGgb043888@repo.freebsd.org> <174719d0148.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200909135114.GC61041@FreeBSD.org> <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200911125525.GC61041@FreeBSD.org> <6d1dd875-c0d6-0006-d829-905534728589@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--JMkwMgK6e0iG7uLb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 11, 2020 at 09:56:31PM +0500, Ruslan Garipov wrote: > On 9/11/2020 5:55 PM, Glen Barber wrote: > > So as far as you are concerned, with the addition of removing the '!', > > it works as you expect? > Yes, it does. >=20 > Should we also "fix" env_setup()? Which also checks NOGIT for zero > length. What if one set NOGIT up outside release.conf as NOGIT=3D1 (I > don't do that). Does he/she end up with "The devel/git is required"? Yes, you are correct. I made the same mistake twice... I will commit it shortly with both things fixed. Glen --JMkwMgK6e0iG7uLb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl9brTQACgkQAxRYpUeP 4pPz6g/8CaJZI/60eoQPBMbcDca5lPTIXUz7DC1LzC7XOvRz3wD7kthur49cvBUP oOq6Qg4ziFo45hRVus5Ckrocqrn6Oj6HP51W9+Yp8QKWjeK8IofMTduOY8KzzzkU AkdXQ7VZhig9b8Yr2v9PtHU1L09QpDKBkIgfXYU2Wn/8ZWhblN77b0fzWHwTPg25 m4kE19odRrgxp5WS4qfaIzNLbE04N5l0Iof87xefpX+M17BiGlk0CEV9z+ZzK9oL Ta3nsNRfXpHW1bt85x6XEIS+mDmomZGJkYQo2NlVJTnp1HbaDs+LFOt6SDpJ3erN J2I5KZQ/7xfO62au1hWsZ8DfpVXwKcWPbKwqENXC9WD5Rm+WNS+/wrHzl+A3viQu iKE9kXFoExqVsHNwlo4J1ckfDc1OqjPokB0Uc5PbO8KcDdyQrQHkkT/9+xlO1oxE 12CykEl2KzxaRPy6EFyh2mC/SJ+k2h58BmnzMpqN3WnxS1Bv/TTfoLr5fFzyOx8f VFRzyuFzhanFh7N1WUWpPLxr8wh9K7F3x7A4RB576ZYr3SR9cjH92SEzq9xGi5et DGnj/AowFC0/U7KQ5QbEqyhvKShkSj0wVdhPXJHH0zWjW3QDY22OCCPu1gLwFD7+ g1Em6Ga1dqTJLm26Tgu0Wdg0TU3zzI/f7C3hclEsvu7QDCUlBGE= =/NnJ -----END PGP SIGNATURE----- --JMkwMgK6e0iG7uLb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200911170036.GD61041>