Date: Sat, 25 Jun 2005 13:48:42 +0200 From: Maxime Henrion <mux@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: [patch] ep(4) panic Message-ID: <20050625114842.GJ14567@elvis.mu.org> In-Reply-To: <20050625064229.GA56086@ip.net.ua> References: <42BCA0A0.8040902@savvis.net> <20050625064229.GA56086@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote: > On Fri, Jun 24, 2005 at 05:09:04PM -0700, Maksim Yevmenkin wrote: > > Dear Hackers, > > > > my -current panics when i insert ep(4) pcmcia network adapter. following > > is the patch to fix the panic. > > > > --- if_ep_pccard.c.orig Fri Jun 10 12:04:44 2005 > > +++ if_ep_pccard.c Fri Jun 24 16:51:12 2005 > > @@ -73,6 +73,7 @@ > > struct ep_board *epb = &sc->epb; > > const char *desc; > > uint16_t result; > > + u_char eaddr[6]; > > int error; > > > > error = ep_alloc(dev); > > @@ -120,7 +121,7 @@ > > * Newer cards supported by this device need to have their > > * MAC address set. > > */ > > - error = ep_get_macaddr(sc, (u_char *)&IFP2ENADDR(sc->ifp)); > > + error = ep_get_macaddr(sc, eaddr); > > > > ep_free(dev); > > return (0); > > > That's odd. You're saving the MAC address nowhere (it's reused > later). But ep_get_macaddr() does a little bit more than what its name suggests. Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050625114842.GJ14567>