Date: Tue, 15 Nov 2005 09:58:52 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: src-committers@FreeBSD.org, ariff@FreeBSD.org, Alexander Kabaev <kan@FreeBSD.org>, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, arr@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c Message-ID: <20051115095801.M61850@fledge.watson.org> In-Reply-To: <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 15 Nov 2005, Alexander Leidinger wrote:
>> Modified files:
>> sys/dev/sound/pcm channel.c
>> Log:
>> Unbreak kernel builds.
>>
>> Submitted by: arr
>
> Hos does the change from "min & (min-1) == 0" to "(min & (min-1)) == 0"
> fix the building of a kernel (what was the error message from gcc)?
Probably a combination of -Wall and -Werror, which generally generates a
warning along the following lines:
warning: suggest parentheses around comparison in operand of &
Robert N M Watson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051115095801.M61850>