Date: Thu, 29 Sep 2011 20:01:11 -0400 From: Arnaud Lacombe <lacombar@gmail.com> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: Jaakko Heinonen <jh@freebsd.org>, freebsd-current@freebsd.org Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0 Message-ID: <CACqU3MVETRAYg55y5wxMtShhGXwYBCavJUb%2B%2Bv0NLJAwu%2BDu7g@mail.gmail.com> In-Reply-To: <CAG=rPVcLUqs14VfxKffDBWCoBG7u=C5dV45n3ameRXzu5rqHvQ@mail.gmail.com> References: <4E811FF7.7010607@a1poweruser.com> <4E8126D3.5020407@FreeBSD.org> <CAG=rPVeAPt0_=jNXaHcnB8QCtYuvi5z69MDMFEgyD0HBQT0Mcw@mail.gmail.com> <4E812DB7.3000302@FreeBSD.org> <CAG=rPVcTHiPLFG1%2BdZmi1OWpyZsw=Px=PJT55UFGN_mxt3y%2BJw@mail.gmail.com> <alpine.BSF.2.00.1109262027460.81576@toaster.local> <CAG=rPVeYjqZJuEzVG_kf%2B29bZx%2BZ%2B7du6DsoFou92WDx78B5Dg@mail.gmail.com> <alpine.BSF.2.00.1109262106390.81576@toaster.local> <CAJ-VmokTFaG09=3S8Fw1RwYDJ-Q2OXd0rox6e5AW1DBR4W1AjA@mail.gmail.com> <CAG=rPVdhqhjPEwHGhHBoOYB6rTX=UD2%2B-ehK8-6oT93M5Ec5Tg@mail.gmail.com> <20110928081514.GA5077@jh> <CAG=rPVcLUqs14VfxKffDBWCoBG7u=C5dV45n3ameRXzu5rqHvQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Thu, Sep 29, 2011 at 6:20 PM, Craig Rodrigues <rodrigc@crodrigues.org> w=
rote:
> On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen <jh@freebsd.org> wrote:
>>
>> I think that using the FEATURE() macro and feature_present(3) might be
>> more appropriate for this.
>>
>> Thanks.
>> --
>> Jaakko
>>
>
> Oh, OK. =A0I was unfamiliar with these API's because they are new in Free=
BSD 8. :)
> How about the attached patch?
--- usr.sbin/burncd/burncd.c (revision 225368)
+++ usr.sbin/burncd/burncd.c (working copy)
@@ -82,6 +82,15 @@
int block_size =3D 0, block_type =3D 0, cdopen =3D 0, dvdrw =3D 0;
const char *dev, *env_speed;
+ if (feature_present("ata_cam")) {
+ printf("\nATA_CAM option is enabled in kernel.\n"
+ "Install the sysutils/cdrtools port and use cdrecord "
+ "instead.\n\n"
maybe could you avoid the line break here, this makes the sentence
un-grepable. You are breaking the 80-char limit anyway with the URL.
- Arnaud
+ "Please refer to:\n"
+ "http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD\n");
+ exit(1);
>
> --
> Craig Rodrigues
> rodrigc@crodrigues.org
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org=
"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACqU3MVETRAYg55y5wxMtShhGXwYBCavJUb%2B%2Bv0NLJAwu%2BDu7g>