Date: Wed, 26 Oct 2005 11:08:04 -0600 From: Scott Long <scottl@samsco.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov <ru@FreeBSD.org>, cvs-all@FreeBSD.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: cvs commit: src/sys/netgraph/bluetooth/drivers/bt3c ng_bt3c_pccard.c Message-ID: <435FB7F4.6020700@samsco.org> In-Reply-To: <bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com> References: <200510260617.j9Q6HRqh082376@repoman.freebsd.org> <200510261100.55974.jhb@freebsd.org> <bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maksim Yevmenkin wrote: > John, > > [...] > > >>Sorry about that, will be fixing it more cleanly. BTW, does anyone know why >>this driver allocates its softc manualn in its attach routine? > > > ng_bt3c(4) is a netgraph device driver. there could be failures in > both device part (i/o port, interrupts etc.) as well as in netgraph > part (could not create node). so decided to do it this way. right now > i can not recall any other reason :) > > thanks, > max If the driver is attaching via normal newbus methods, and the bluetooth stack hasn't done something strange to override this, then there is no need to not trust the softc that is automatically provided. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?435FB7F4.6020700>