Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Jan 2018 17:36:27 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Eitan Adler <lists@eitanadler.com>
Cc:        Li-Wen Hsu <lwhsu@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r327616 - head/usr.bin/morse
Message-ID:  <8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4@FreeBSD.org>
In-Reply-To: <CAF6rxgkEUWztBOc92rxpH8M_AbkbtMw0w=Ah3VS=dbS6_U8taQ@mail.gmail.com>
References:  <201801060948.w069m4Rb058364@repo.freebsd.org> <CAF6rxgkEUWztBOc92rxpH8M_AbkbtMw0w=Ah3VS=dbS6_U8taQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On 6 Jan 2018, at 14:19, Eitan Adler <lists@eitanadler.com> wrote:
>=20
> On 6 January 2018 at 01:48, Li-Wen Hsu <lwhsu@freebsd.org> wrote:
>> Author: lwhsu (ports committer)
>> Date: Sat Jan  6 09:48:04 2018
>> New Revision: 327616
>> URL: https://svnweb.freebsd.org/changeset/base/327616
>>=20
>> Log:
>>  Unbreak build after r327614
>=20
> Why is testing with "make obj; make" in the morse directory =
insufficient?
>=20
> =E2=88=B4make obj; make
> rm -f .depend
> echo morse.full: /usr/lib/libc.a  >> .depend
> cc  -O2 -pipe   -g -MD  -MF.depend.morse.o -MTmorse.o -std=3Dgnu99
> -fstack-protector-strong -Wsystem-headers -Werror -Wall
> -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual
> -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align
> -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -Wold-style-definition -Wno-pointer-sign
> -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body
> -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments
> -c morse.c -o morse.o
> cc -O2 -pipe -g -std=3Dgnu99 -fstack-protector-strong -Wsystem-headers
> -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter
> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs
> -Wredundant-decls -Wold-style-definition -Wno-pointer-sign
> -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body
> -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments  -o
> morse.full morse.o
> objcopy --only-keep-debug morse.full morse.debug
> objcopy --strip-debug --add-gnu-debuglink=3Dmorse.debug  morse.full =
morse
> gzip -cn morse.6 > morse.6.gz

Before r327616, I get:

usr.bin/morse/morse.c:602:15: error: unused parameter 'stream' =
[-Werror,-Wunused-parameter]
fdecode(FILE *stream)
              ^
1 error generated.

Maybe you have warnings turned off in your local build environment?

-Dimitry


--Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWlD7CwAKCRCwXqMKLiCW
ownYAKD6zqug9YWDGAICrc3FEResthNZkACfbH9sqM4pzQYTIqzFDfBJDk5GqLE=
=C8du
-----END PGP SIGNATURE-----

--Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4>