Date: Sun, 26 Jun 2011 19:03:33 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r223579 - head/contrib/traceroute Message-ID: <201106261903.p5QJ3XT4064345@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Sun Jun 26 19:03:33 2011 New Revision: 223579 URL: http://svn.freebsd.org/changeset/base/223579 Log: For some reason, contrib/traceroute/traceroute.c ensures MAXHOSTNAMELEN is defined, but then proceeds to use a hardcoded maximum hostname length of 64 anyway. Fix this by checking against MAXHOSTNAMELEN instead. PR: bin/157732 MFC after: 3 days Modified: head/contrib/traceroute/traceroute.c Modified: head/contrib/traceroute/traceroute.c ============================================================================== --- head/contrib/traceroute/traceroute.c Sun Jun 26 19:02:34 2011 (r223578) +++ head/contrib/traceroute/traceroute.c Sun Jun 26 19:03:33 2011 (r223579) @@ -1618,7 +1618,7 @@ gethostinfo(register char *hostname) register char **p; register u_int32_t addr, *ap; - if (strlen(hostname) > 64) { + if (strlen(hostname) >= MAXHOSTNAMELEN) { Fprintf(stderr, "%s: hostname \"%.32s...\" is too long\n", prog, hostname); exit(1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106261903.p5QJ3XT4064345>