Date: Sun, 28 Jan 2024 13:19:20 GMT From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: c053a56c0f5d - main - hdaa_pcmchannel_setup: do not advertise AC3 8+0 Message-ID: <202401281319.40SDJKvt040856@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=c053a56c0f5df6db5223316831142e1d8afff64f commit c053a56c0f5df6db5223316831142e1d8afff64f Author: Andriy Gapon <avg@FreeBSD.org> AuthorDate: 2024-01-28 13:18:02 +0000 Commit: Andriy Gapon <avg@FreeBSD.org> CommitDate: 2024-01-28 13:18:55 +0000 hdaa_pcmchannel_setup: do not advertise AC3 8+0 The rest of the sound system supports 7+1 maximum and is not aware of 8+0. I believe that these messages are caused by 8+0: kernel: feeder_init(0xfffff801f935d680) on feeder_matrix returned 22 kernel: pcm0: feeder_build_matrix(): can't add feeder_matrix --- sys/dev/sound/pci/hda/hdaa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c index 02f4babcd331..dcd10cb36510 100644 --- a/sys/dev/sound/pci/hda/hdaa.c +++ b/sys/dev/sound/pci/hda/hdaa.c @@ -5426,7 +5426,6 @@ hdaa_pcmchannel_setup(struct hdaa_chan *ch) if (HDA_PARAM_SUPP_STREAM_FORMATS_AC3(fmtcap)) { ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 2, 0); if (channels >= 8) { - ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 8, 0); ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 8, 1); } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202401281319.40SDJKvt040856>