Date: Sat, 09 Dec 2006 20:42:15 -0400 From: "Marc G. Fournier" <scrappy@hub.org> To: Peter Pentchev <roam@ringlet.net>, LI Xin <delphij@delphij.net> Cc: freebsd@orchid.homeunix.org, ports@freebsd.org, dd@freebsd.org Subject: Re: bsdstats 5.3 on 6-STABLE and netcat weirdness Message-ID: <A6CE73D9D3F6AFC6FD436725@ganymede.hub.org> In-Reply-To: <20061208200755.GA16586@straylight.m.ringlet.net> References: <4576A4F6.7070407@orchid.homeunix.org> <8194EEE8E22BA574C20015C8@ganymede.hub.org> <4576D15A.2070101@delphij.net> <20061208200755.GA16586@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
patch committed ...
- --On Friday, December 08, 2006 22:07:55 +0200 Peter Pentchev
<roam@ringlet.net>
wrote:
> On Wed, Dec 06, 2006 at 10:19:06PM +0800, LI Xin wrote:
>> Marc G. Fournier wrote:
>> >
>> > 'k, I don't know how to fix this one ... I thought about doing:
>> >
>> > .if ${OSVERSION} <= 492101
>> > RUN_DEPENDS= nc:${PORTSDIR}/net/netcat
>> > .endif
>> >
>> > not sure which version brought in nc, but 492101 is the last of the 4.x
>> > series ... but it portlint fails miserably if I don't put bsd.port.pre.mk
>> > before it, but also fails if I do:
>> >
>> > WARN: Makefile: no MASTER_SITES found. is it ok?
>> > WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
>> > 0 fatal errors and 2 warnings found.
>> >
>> > Is there a better way of doing this ... ?
>>
>> I think you want something like:
>>
>> .if ${OSVERSION} < 503102 || (${OSVERSION} >= 600000 && ${OSVERSION} <
>> 600010)
>>
>> instead of just considering 492101.
>
> That's a good suggestion.
>
> Mark, as to the portlint problem - well, portlint cannot really be
> expected to handle each and every corner case in a port Makefile :)
> It is doing a wonderful job as it is, but every now and then you have
> to make a choice between a working port and a clean port ;)
>
> To make the OSVERSION check work, you do indeed need a bsd.port.pre.mk
> inclusion before it. Then... just ignore the portlint warnings.
>
> And... thanks for a great utility! :)
>
> G'luck,
> Peter
>
> --
> Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org
> PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
> Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
> I am the meaning of this sentence.
- ----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email . scrappy@hub.org MSN . scrappy@hub.org
Yahoo . yscrappy Skype: hub.org ICQ . 7615664
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFFe1fo4QvfyHIvDvMRAvjnAKCZfqn/io3z0lZ6cP36dlgIsjNiDwCgr0i9
B5SAjpaOL35Dr+XSt6QI5l8=
=Eqle
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A6CE73D9D3F6AFC6FD436725>