Date: Mon, 15 Jul 2013 11:36:16 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org> To: Andre Oppermann <andre@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253210 - in head/sys: conf netinet Message-ID: <20130715093615.GC2294@acme.spoerlein.net> In-Reply-To: <201307111529.r6BFTPSf016809@svn.freebsd.org> References: <201307111529.r6BFTPSf016809@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey Andre,
I don't see why this commit triggers it, but Coverity Scan found a new
resource leak in this file. syncache_expand() will leak *s when line
1071 is reached. The "failed:" case below correctly frees the resources.
1068/* how do we find the inp for the new socket? */
22. Condition "sc != &scs", taking true branch
1069 if (sc != &scs)
1070 syncache_free(sc);
CID null (#1 of 1): Resource leak (RESOURCE_LEAK)
23. leaked_storage: Variable "s" going out of scope leaks the storage it points to.
1071 return (1);
1072failed:
1073 if (sc != NULL && sc != &scs)
1074 syncache_free(sc);
1075 if (s != NULL)
1076 free(s, M_TCPLOG);
1077 *lsop = NULL;
1078 return (0);
1079}
This has no CID yet ...
Cheers,
Uli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130715093615.GC2294>