Date: Tue, 26 Sep 2023 18:34:06 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Ravi Pokala <rpokala@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Mateusz Guzik <mjg@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag Message-ID: <FA6AAA38-C132-44A8-9FE4-7365FA41980A@freebsd.org> In-Reply-To: <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com> <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Sep 2023, at 18:32, Ravi Pokala <rpokala@freebsd.org> wrote: >=20 > In that case, an updated comment seems appropriate, so it=E2=80=99s = not removed again. https://reviews.freebsd.org/D41984 > -Ravi (rpokala@) >=20 > From: <owner-src-committers@freebsd.org> on behalf of Warner Losh = <imp@bsdimp.com> > Date: Tuesday, September 26, 2023 at 07:51 > To: Mateusz Guzik <mjg@freebsd.org> > Cc: src-committers <src-committers@freebsd.org>, = "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, = "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> > Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack = sccs tag >=20 > Can you put this back? It is still useful. I have automated scripts = that look for this pattern to find the version of a core dump. There are = no other ways that are as reliable to find this data. Some other = heuristics exist, but my experience with snagging data from maybe a = thousand core dumps from $WORK's network found issues in all the = alternatives. It's why I didn't whack it already. Even though the text = says SCCS which is prehistory for this project, it's still in use today. > Warner >=20 > On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote: >>=20 >>=20 >> The branch main has been updated by mjg: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c5= fd417723 >>=20 >> commit e6dc6a27230f836a131118326731b7c5fd417723 >> Author: Mateusz Guzik <mjg@FreeBSD.org> >> AuthorDate: 2023-09-26 14:36:51 +0000 >> Commit: Mateusz Guzik <mjg@FreeBSD.org> >> CommitDate: 2023-09-26 14:36:51 +0000 >>=20 >> sys/conf/newvers.sh: whack sccs tag >>=20 >> In the same spirit as removing cvs $FreeBSD$ tags. >>=20 >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> --- >> sys/conf/newvers.sh | 2 -- >> 1 file changed, 2 deletions(-) >>=20 >> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh >> index 73fd6857d307..18b1817ca287 100644 >> --- a/sys/conf/newvers.sh >> +++ b/sys/conf/newvers.sh >> @@ -311,11 +311,9 @@ fi >>=20 >> vers_content_new=3D$(cat << EOF >> $COPYRIGHT >> -#define SCCSSTR "@(#)${VERINFO}" >> #define VERSTR "${VERSTR}" >> #define RELSTR "${RELEASE}" >>=20 >> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D = SCCSSTR; >> char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] =3D = VERSTR; >> char compiler_version[] =3D "${compiler_v}"; >> char ostype[] =3D "${TYPE}";
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FA6AAA38-C132-44A8-9FE4-7365FA41980A>