Date: Wed, 22 Jul 2015 14:44:34 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r392666 - head/audio/libgroove Message-ID: <de0f94bb48432295c450da4dffbd4ba6@gahr.ch> In-Reply-To: <20150722122531.GB50653@FreeBSD.org> References: <201507220652.t6M6qVFO094263@repo.freebsd.org> <d4dfd69de717fd8d4e5ef472408644e1@gahr.ch> <20150722122313.GA50653@FreeBSD.org> <20150722122531.GB50653@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2015-07-22 14:25, Alexey Dokuchaev wrote: > On Wed, Jul 22, 2015 at 12:23:13PM +0000, Alexey Dokuchaev wrote: >> On Wed, Jul 22, 2015 at 01:49:37PM +0200, Pietro Cerutti wrote: >> > > @@ -1,29 +1,29 @@ >> > > -# Created by: gahr >> > > +# Created by: Pietro Cerutti <gahr@FreeBSD.org> >> > >> > I would have appreciated you notifying me of such change. >> > Is this modification really needed? >> >> It's obviously not *really* needed as it touches Makefile header, thus >> being >> non-functional. On on the other hand, we're not forbidding >> non-functional >> changes, right? :) [...] >> >> > Are you going to change all similar occurrences in the ports tree? >> >> I won't convert them in bulk, most certainly. I do expand them when I >> notice one (and was not asked to leave that/those particular one >> alone). In clear contrast with the PHB, which states "If this line is present, future maintainers must not change or remove it except at the original author's request." It does *not* say "Future maintainers can change it if not explicitly asked not to.". Look, we do have rules so we don't have to argue about taste, style, what's more sensible to you, etc. > Sorry I forgot to ask: so any problem with expansion? Yes, I do. Please revert. -- Pietro Cerutti gahr@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?de0f94bb48432295c450da4dffbd4ba6>