Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Sep 2025 09:05:32 GMT
From:      Robert Clausecker <fuz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 7feac79331bc - main - libc/aarch64: fix ELF size of timingsafe_memcmp
Message-ID:  <202509260905.58Q95WTV090461@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by fuz:

URL: https://cgit.FreeBSD.org/src/commit/?id=7feac79331bc8c77e2f8a3e71d6ea087fa17b61d

commit 7feac79331bc8c77e2f8a3e71d6ea087fa17b61d
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2025-09-25 19:49:08 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-09-26 09:04:54 +0000

    libc/aarch64: fix ELF size of timingsafe_memcmp
    
    Looks like a copy and paste error.
    The ELF size of 0 prevents Valgrind from redirecting this function.
    
    PR:             289845
    Reviewed by:    fuz
    Fixes:          3f224333af163d5fcd7547a20993dcf18f19076c
    See also:       https://bugs.kde.org/show_bug.cgi?id=509406
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/1854
    MFC after:      1 day
    Event:          EuroBSDcon 2025
---
 lib/libc/aarch64/string/timingsafe_memcmp.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/libc/aarch64/string/timingsafe_memcmp.S b/lib/libc/aarch64/string/timingsafe_memcmp.S
index 28fdd911a387..4cc10a152aa8 100644
--- a/lib/libc/aarch64/string/timingsafe_memcmp.S
+++ b/lib/libc/aarch64/string/timingsafe_memcmp.S
@@ -114,4 +114,4 @@ ENTRY(timingsafe_memcmp)
 	csetm	w0, lo
 	csinc	w0, w0, wzr, ls
 	ret
-END(timingsafe_bcmp)
+END(timingsafe_memcmp)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509260905.58Q95WTV090461>