Date: Thu, 17 Nov 2011 23:08:40 -0500 From: Ken Smith <kensmith@buffalo.edu> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>, John Baldwin <jhb@freebsd.org>, svn-src-all@freebsd.org, David Chisnall <theraven@freebsd.org>, TAKAHASHI Yoshihiro <nyan@freebsd.org>, Nathan Whitehorn <nwhitehorn@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r227536 - in head: release share/man/man7 Message-ID: <4EC5DA48.6060002@buffalo.edu> In-Reply-To: <20111118030019.GA37436@FreeBSD.org> References: <201111151849.pAFInR3K012609@svn.freebsd.org> <201111171141.22648.jhb@freebsd.org> <1321551793.82271.55.camel@bauer.cse.buffalo.edu> <201111171416.47725.jhb@freebsd.org> <20111118030019.GA37436@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/17/11 10:00 PM, Alexey Dokuchaev wrote:
> On Thu, Nov 17, 2011 at 02:16:47PM -0500, John Baldwin wrote:
>> On Thursday, November 17, 2011 12:43:12 pm Ken Smith wrote:
>>> If you're referring to the FTP directory tree layout we wind up
>>> with:
>>>
>>> .../releases/amd64/9.0-RELEASE
>>> .../releases/amd64/ISO-IMAGES/9.0
>>>
>>> for an example of uname -m == uname -p. But for our two
>>> powerpc related architectures we get:
>>>
>>> .../releases/powerpc/9.0-RELEASE
>>> .../releases/powerpc/ISO-IMAGES/9.0
>>> .../releases/powerpc/powerpc64/9.0-RELEASE
>>> .../releases/powerpc/powerpc64/ISO-IMAGES/9.0
>>>
>>> I'm not sure I like the inconsistency.
>>
>> Given the available tradeoffs I prefer this to amd64/amd64. We
>> could also define the rule another way, which is if a given
>> TARGET only has a single TARGET_ARCH you just use TARGET,
>> otherwise you use TARGET/TARGET_ARCH.
>
> If we seem to employ some naming transition rule based on
> TARGET_ARCH and TARGET, why not simply check just for pc98 as I
> suggested earlier, and return TARGET in this case, and TARGET_ARCH
> otherwise?
>
> Generalizing, perhaps this rule can be extended to the list of
> TARGET/TARGET_ARCH combos for which we return TARGET, and
> TARGET_ARCH for the rest?
>
> (This is for ISO file names; for release directory structure
> John's suggestion looks reasonable.)
>
> ./danfe
>
Can you suggest a patch to src/usr.sbin/bsdinstall/scripts/mirrorselect
that implements it then? I can picture a patch that just checks to see
if uname -p == uname -m but I'm having trouble picturing a patch that
implements anything more complicated than that in a way that's not
a hack of checks for special cases.
- --
Ken Smith
- - From there to here, from here to | kensmith@buffalo.edu
there, funny things are everywhere. |
- Theodor Geisel |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7F2kgACgkQ/G14VSmup/YLVACgmB8gCrOjUREzjRJh+34UlU9i
Q6wAoJGX0wsCjFpf/PYGGUvq04TYqBGL
=s8IE
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EC5DA48.6060002>