Date: Tue, 13 Nov 2001 12:27:01 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Max Khon <fjoe@iclub.nsu.ru> Cc: current@freebsd.org Subject: RE: initgroups Message-ID: <XFMail.011113122701.jhb@FreeBSD.org> In-Reply-To: <20011114021956.B10325@iclub.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13-Nov-01 Max Khon wrote:
> hi, there!
>
> Any objections if I will commit the following patch (see PR/15421)?
>
> Index: initgroups.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
> retrieving revision 1.4
> diff -u -r1.4 initgroups.c
> --- initgroups.c 2001/08/29 13:52:26 1.4
> +++ initgroups.c 2001/11/13 20:17:03
> @@ -59,9 +59,5 @@
> if (getgrouplist(uname, agroup, groups, &ngroups) < 0)
> warnx("%s is in too many groups, using first %d",
> uname, ngroups);
> - if (setgroups(ngroups, groups) < 0) {
> - _warn("setgroups");
> - return (-1);
> - }
> - return (0);
> + return setgroups(ngroups, groups);
> }
Style nit:
return (setgruops(ngroups, groups));
Also, commit the manpage patch in the PR as well.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011113122701.jhb>