Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Sep 2014 15:05:11 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r271512 - vendor-sys/illumos/dist/uts/common/fs/zfs
Message-ID:  <201409131505.s8DF5BpZ066125@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: delphij
Date: Sat Sep 13 15:05:10 2014
New Revision: 271512
URL: http://svnweb.freebsd.org/changeset/base/271512

Log:
  5136 fix write throttle comment in dsl_pool.c
  Reviewed by: Adam Leventhal <ahl@delphix.com>
  Reviewed by: Christopher Siden <christopher.siden@delphix.com>
  Reviewed by: Max Grossman <max.grossman@delphix.com>
  Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
  Reviewed by: Richard Elling <richard.elling@gmail.com>
  Approved by: Dan McDonald <danmcd@omniti.com>
  Author: Matthew Ahrens <mahrens@delphix.com>
  
  illumos/illumos-gate@d85a1e969ce08b3bc4a7cb3626a6e33a28b5caeb

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_pool.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_pool.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_pool.c	Sat Sep 13 14:30:46 2014	(r271511)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_pool.c	Sat Sep 13 15:05:10 2014	(r271512)
@@ -111,8 +111,8 @@ int zfs_delay_min_dirty_percent = 60;
 
 /*
  * This controls how quickly the delay approaches infinity.
- * Larger values cause it to delay less for a given amount of dirty data.
- * Therefore larger values will cause there to be more dirty data for a
+ * Larger values cause it to delay more for a given amount of dirty data.
+ * Therefore larger values will cause there to be less dirty data for a
  * given throughput.
  *
  * For the smoothest delay, this value should be about 1 billion divided
@@ -125,12 +125,6 @@ int zfs_delay_min_dirty_percent = 60;
 uint64_t zfs_delay_scale = 1000 * 1000 * 1000 / 2000;
 
 
-/*
- * XXX someday maybe turn these into #defines, and you have to tune it on a
- * per-pool basis using zfs.conf.
- */
-
-
 hrtime_t zfs_throttle_delay = MSEC2NSEC(10);
 hrtime_t zfs_throttle_resolution = MSEC2NSEC(10);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409131505.s8DF5BpZ066125>