Date: Wed, 12 Mar 2014 12:48:38 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r347897 - head/devel/git Message-ID: <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org> In-Reply-To: <AE1AAB14BF419A28B0CE399B@atuin.in.mat.cc> References: <201403111758.s2BHwmaJ008196@svn.freebsd.org> <AE1AAB14BF419A28B0CE399B@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Mar 2014 11:09:02 +0100 Mathieu Arnold wrote: >+--On 11 mars 2014 17:58:48 +0000 Tijl Coosemans <tijl@FreeBSD.org> wrote: >| Author: tijl >| Date: Tue Mar 11 17:58:47 2014 >| New Revision: 347897 >| URL: http://svnweb.freebsd.org/changeset/ports/347897 >| QAT: https://qat.redports.org/buildarchive/r347897/ >| >| Log: >| Prevent detection of libcharset.h from converters/libiconv. >| >| This forces git to use nl_langinfo() from libc instead of >| locale_charset() from libiconv. (The latter is practically an alias >| for the first.) > > This need a PORTREVISION bump, doesn't it ? I decided not to bump it, but it is an edge case. This commit fixes a build error on FreeBSD 10 with libiconv installed. When libiconv is not installed it does not change anything. On FreeBSD 8 and 9 it does change git to use nl_langinfo() instead of locale_charset() but these functions are the same and git still links with libiconv for other functions. So the dependencies stay the same, pkg-plist stays the same and the overall functionality stays the same.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140312124838.4e7fcdea>