Date: Wed, 26 Oct 2005 12:58:49 -0400 From: John Baldwin <jhb@freebsd.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Ruslan Ermilov <ru@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph/bluetooth/drivers/bt3c ng_bt3c_pccard.c Message-ID: <200510261258.51651.jhb@freebsd.org> In-Reply-To: <bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com> References: <200510260617.j9Q6HRqh082376@repoman.freebsd.org> <200510261100.55974.jhb@freebsd.org> <bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 26 October 2005 12:33 pm, Maksim Yevmenkin wrote: > John, > > [...] > > > Sorry about that, will be fixing it more cleanly. BTW, does anyone know > > why this driver allocates its softc manualn in its attach routine? > > ng_bt3c(4) is a netgraph device driver. there could be failures in > both device part (i/o port, interrupts etc.) as well as in netgraph > part (could not create node). so decided to do it this way. right now > i can not recall any other reason :) Even if netgraph fails then new-bus will still free it for you when attach returns ENXIO. All you have to do is set the size in your driver_t and axe the malloc, free, and device_set_softc calls and you should be done. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510261258.51651.jhb>