Date: Sat, 29 Jan 2000 18:31:07 +0000 (GMT) From: Nick Hibma <n_hibma@webweaving.org> To: FreeBSD CURRENT Mailing List <current@FreeBSD.ORG> Subject: OHCI patch for ohci_hash_find_td panic Message-ID: <Pine.BSF.4.20.0001291830520.7678-200000@localhost>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1522841054-949170646=:7678 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: <Pine.BSF.4.20.0001291830522.7678@localhost> Everyone who has seen the ohci_hash_find_td not found panic should try this one and let me know whether the machine panics or not and where. This patch is against CURRENT. It looks like the hardware kind of deviates from the OHCI spec when putting things on the Done queue in case of an error. Important: Your system will panic and completely destroy your filesystem. If it doesn't you got lucky. Cheers, Nick -- n_hibma@webweaving.org n_hibma@freebsd.org USB project http://www.etla.net/~n_hibma/ --0-1522841054-949170646=:7678 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="ohci.c.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.4.20.0001291830460.7678@localhost> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="ohci.c.diff" SW5kZXg6IG9oY2kuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9ob21lL25jdnMvc3JjL3N5cy9kZXYvdXNiL29oY2kuYyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMzYNCmRpZmYgLXcgLXUgLXIxLjM2IG9oY2ku Yw0KLS0tIG9oY2kuYwkyMDAwLzAxLzI5IDE2OjI1OjU1CTEuMzYNCisrKyBv aGNpLmMJMjAwMC8wMS8yOSAxNzowNDo0NA0KQEAgLTkxLDcgKzkxLDcgQEAN CiAjaWZkZWYgT0hDSV9ERUJVRw0KICNkZWZpbmUgRFBSSU5URih4KQlpZiAo b2hjaWRlYnVnKSBsb2dwcmludGYgeA0KICNkZWZpbmUgRFBSSU5URk4obix4 KQlpZiAob2hjaWRlYnVnPihuKSkgbG9ncHJpbnRmIHgNCi1pbnQgb2hjaWRl YnVnID0gMDsNCitpbnQgb2hjaWRlYnVnID0gMTsNCiAjZWxzZQ0KICNkZWZp bmUgRFBSSU5URih4KQ0KICNkZWZpbmUgRFBSSU5URk4obix4KQ0KQEAgLTQx Nyw2ICs0MTcsNyBAQA0KIAl1c2JkX3N0YXR1cyBlcnI7DQogCWludCBpLCBv ZmZzOw0KIAl1c2JfZG1hX3QgZG1hOw0KKwlpbnQgczsNCiANCiAJaWYgKHNj LT5zY19mcmVldGRzID09IE5VTEwpIHsNCiAJCURQUklOVEZOKDIsICgib2hj aV9hbGxvY19zdGQ6IGFsbG9jYXRpbmcgY2h1bmtcbiIpKTsNCkBAIC00MzYs NiArNDM3LDExIEBADQogCXNjLT5zY19mcmVldGRzID0gc3RkLT5uZXh0dGQ7 DQogCW1lbXNldCgmc3RkLT50ZCwgMCwgc2l6ZW9mKG9oY2lfdGRfdCkpOw0K IAlzdGQtPm5leHR0ZCA9IE5VTEw7DQorDQorCXMgPSBzcGx1c2IoKTsNCisJ b2hjaV9oYXNoX2FkZF90ZChzYywgc3RkKTsNCisJc3BseChzKTsNCisNCiAJ cmV0dXJuIChzdGQpOw0KIH0NCiANCkBAIC00NDQsNiArNDUwLDEyIEBADQog CW9oY2lfc29mdGNfdCAqc2M7DQogCW9oY2lfc29mdF90ZF90ICpzdGQ7DQog ew0KKwlpbnQgczsNCisNCisJcyA9IHNwbHVzYigpOw0KKwlvaGNpX2hhc2hf cmVtX3RkKHNjLCBzdGQpOw0KKwlzcGx4KHMpOw0KKw0KIAlzdGQtPm5leHR0 ZCA9IHNjLT5zY19mcmVldGRzOw0KIAlzYy0+c2NfZnJlZXRkcyA9IHN0ZDsN CiB9DQpAQCAtMTEyNyw3ICsxMTM5LDggQEANCiAjaWZkZWYgT0hDSV9ERUJV Rw0KIAlpZiAob2hjaWRlYnVnID4gMTApIHsNCiAJCURQUklOVEYoKCJvaGNp X3Byb2Nlc3NfZG9uZTogVEQgZG9uZTpcbiIpKTsNCi0JCW9oY2lfZHVtcF90 ZHMoc2RvbmUpOw0KKwkJZm9yIChzdGQgPSBzZG9uZTsgc3RkOyBzdGQgPSBz dGQtPmRuZXh0KQ0KKwkJCW9oY2lfZHVtcF90ZChzZG9uZSk7DQogCX0NCiAj ZW5kaWYNCiANCkBAIC0xMTM1LDcgKzExNDgsMTYgQEANCiAJCXhmZXIgPSBz dGQtPnhmZXI7DQogCQlzdGRuZXh0ID0gc3RkLT5kbmV4dDsNCiAJCURQUklO VEZOKDUsICgib2hjaV9wcm9jZXNzX2RvbmU6IHN0ZD0lcCB4ZmVyPSVwIGhj cHJpdj0lcFxuIiwNCi0JCQkJc3RkLCB4ZmVyLCB4ZmVyLT5oY3ByaXYpKTsN CisJCQkJc3RkLCB4ZmVyLCAoeGZlcj8geGZlci0+aGNwcml2Ok5VTEwpKSk7 DQorCQlpZiAoeGZlciA9PSBOVUxMIHx8IChzdGQtPmZsYWdzICYgT0hDSV9U RF9IQU5ETEVEKSkgew0KKwkJCS8qIHhmZXIgPT0gTlVMTDogVGhlcmUgc2Vl bXMgdG8gYmUgbm8geGZlciBhc3NvY2lhdGVkDQorCQkJICogd2l0aCB0aGlz IFRELiBJdCBpcyB0YWlscCB0aGF0IGhhcHBlbmVkIHRvIGVuZCB1cCBvbg0K KwkJCSAqIHRoZSBkb25lIHF1ZXVlLg0KKwkJCSAqIGZsYWdzICYgT0hDSV9U RF9IQU5ETEVEOiBUaGUgVEQgaGFzIGFscmVhZHkgYmVlbg0KKwkJCSAqIGhh bmRsZWQgYnkgcHJvY2Vzc19kb25lIGFuZCBzaG91bGQgbm90IGJlIGRvbmUg YWdhaW4uDQorCQkJICovDQorCQkJY29udGludWU7DQorCQl9DQogCQljYyA9 IE9IQ0lfVERfR0VUX0NDKExFKHN0ZC0+dGQudGRfZmxhZ3MpKTsNCiAJCXVz Yl91bnRpbWVvdXQob2hjaV90aW1lb3V0LCB4ZmVyLCB4ZmVyLT50aW1vX2hh bmRsZSk7DQogCQlpZiAoeGZlci0+c3RhdHVzID09IFVTQkRfQ0FOQ0VMTEVE IHx8DQpAQCAtMTE1Niw3ICsxMTc4LDYgQEANCiAJCQkJeGZlci0+c3RhdHVz ID0gVVNCRF9OT1JNQUxfQ09NUExFVElPTjsNCiAJCQkJdXNiX3RyYW5zZmVy X2NvbXBsZXRlKHhmZXIpOw0KIAkJCX0NCi0JCQlvaGNpX2hhc2hfcmVtX3Rk KHNjLCBzdGQpOw0KIAkJCW9oY2lfZnJlZV9zdGQoc2MsIHN0ZCk7DQogCQl9 IGVsc2Ugew0KIAkJCS8qDQpAQCAtMTE3MiwxNiArMTE5MywyMyBAQA0KIAkJ CSAgT0hDSV9URF9HRVRfQ0MoTEUoc3RkLT50ZC50ZF9mbGFncykpLA0KIAkJ CSAgb2hjaV9jY19zdHJzW09IQ0lfVERfR0VUX0NDKExFKHN0ZC0+dGQudGRf ZmxhZ3MpKV0sDQogCQkJICB4ZmVyKSk7DQorDQorCQkJLyogTWFyayBhbGwg dGhlIFREcyBpbiB0aGUgZG9uZSBxdWV1ZSBmb3IgdGhlIGN1cnJlbnQNCisJ CQkgKiB4ZmVyIGFzIGhhbmRsZWQNCisJCQkgKi8NCisJCQlmb3IgKHAgPSBz dGRuZXh0OyBwOyBwID0gcC0+ZG5leHQpIHsNCisJCQkJaWYgKHAtPnhmZXIg PT0geGZlcikNCisJCQkJCXAtPmZsYWdzIHw9IE9IQ0lfVERfSEFORExFRDsN CisJCQl9DQogDQotCQkJLyogcmVtb3ZlIFREcyAqLw0KKwkJCS8qIHJlbW92 ZSBURHMgZm9yIHRoZSBjdXJyZW50IHhmZXIgZnJvbSB0aGUgRUQgKi8NCiAJ CQlmb3IgKHAgPSBzdGQ7IHAtPnhmZXIgPT0geGZlcjsgcCA9IG4pIHsNCiAJ CQkJbiA9IHAtPm5leHR0ZDsNCi0JCQkJb2hjaV9oYXNoX3JlbV90ZChzYywg cCk7ICAgICAgICAgICAgICAgICAgICAgICAgDQogCQkJCW9oY2lfZnJlZV9z dGQoc2MsIHApOw0KIAkJCX0NCi0NCi0JCQkvKiBjbGVhciBoYWx0ICovDQog CQkJb3BpcGUtPnNlZC0+ZWQuZWRfaGVhZHAgPSBMRShwLT5waHlzYWRkcik7 DQorDQorCQkJLyogWFhYIHdoeSBpcyB0aGlzIGJlaW5nIGRvbmU/IFdoeSBu b3QgT0hDSV9CTEYgdG9vICovDQogCQkJT1dSSVRFNChzYywgT0hDSV9DT01N QU5EX1NUQVRVUywgT0hDSV9DTEYpOw0KIA0KIAkJCWlmIChjYyA9PSBPSENJ X0NDX1NUQUxMKQ0KQEAgLTE0NjIsMTAgKzE0OTAsNiBAQA0KIA0KIAkvKiBJ bnNlcnQgRUQgaW4gc2NoZWR1bGUgKi8NCiAJcyA9IHNwbHVzYigpOw0KLQlv aGNpX2hhc2hfYWRkX3RkKHNjLCBzZXR1cCk7DQotCWlmIChsZW4gIT0gMCkN Ci0JCW9oY2lfaGFzaF9hZGRfdGQoc2MsIGRhdGEpOw0KLQlvaGNpX2hhc2hf YWRkX3RkKHNjLCBzdGF0KTsNCiAJc2VkLT5lZC5lZF90YWlscCA9IExFKHRh aWwtPnBoeXNhZGRyKTsNCiAJb3BpcGUtPnRhaWwudGQgPSB0YWlsOw0KIAlP V1JJVEU0KHNjLCBPSENJX0NPTU1BTkRfU1RBVFVTLCBPSENJX0NMRik7DQpA QCAtMTg3MCw3ICsxODk0LDYgQEANCiAjZW5kaWYNCiAJZm9yICg7IHAtPnhm ZXIgPT0geGZlcjsgcCA9IG4pIHsNCiAJCW4gPSBwLT5uZXh0dGQ7DQotCQlv aGNpX2hhc2hfcmVtX3RkKHNjLCBwKTsNCiAJCW9oY2lfZnJlZV9zdGQoc2Ms IHApOw0KIAl9DQogDQpJbmRleDogb2hjaXZhci5oDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lzL2Rldi91 c2Ivb2hjaXZhci5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNQ0KZGlm ZiAtdyAtdSAtcjEuMTUgb2hjaXZhci5oDQotLS0gb2hjaXZhci5oCTIwMDAv MDEvMjcgMjM6MjU6NTgJMS4xNQ0KKysrIG9oY2l2YXIuaAkyMDAwLzAxLzI5 IDEyOjI4OjI1DQpAQCAtNTcsNiArNTcsNyBAQA0KIAl1X2ludDE2X3QgZmxh Z3M7DQogI2RlZmluZSBPSENJX0NBTExfRE9ORQkweDAwMDENCiAjZGVmaW5l IE9IQ0lfQUREX0xFTgkweDAwMDINCisjZGVmaW5lIE9IQ0lfVERfSEFORExF RAkweDAwMDQJCS8qIHNpZ25hbCBwcm9jZXNzX2RvbmUgaGFzIHNlZW4gaXQg Ki8NCiB9IG9oY2lfc29mdF90ZF90Ow0KICNkZWZpbmUgT0hDSV9TVERfU0la RSAoKHNpemVvZiAoc3RydWN0IG9oY2lfc29mdF90ZCkgKyBPSENJX1REX0FM SUdOIC0gMSkgLyBPSENJX1REX0FMSUdOICogT0hDSV9URF9BTElHTikNCiAj ZGVmaW5lIE9IQ0lfU1REX0NIVU5LIDEyOA0K --0-1522841054-949170646=:7678-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.20.0001291830520.7678-200000>