Date: Thu, 11 Jul 2013 20:36:58 +0100 From: David Chisnall <theraven@FreeBSD.org> To: Tijl Coosemans <tijl@coosemans.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, David Chisnall <theraven@FreeBSD.org> Subject: Re: svn commit: r253215 - head/lib/msun/src Message-ID: <7D521907-4802-4141-9A5E-40EB157A5AEF@FreeBSD.org> In-Reply-To: <51DEFEF7.4080709@coosemans.org> References: <201307111741.r6BHf5gQ060844@svn.freebsd.org> <51DEFEF7.4080709@coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 11 Jul 2013, at 19:52, Tijl Coosemans <tijl@coosemans.org> wrote: > GCC doesn't support _Generic yet for -std=c11. Ugh. Given that they also lack a fine-grained feature check mechanism, they really should not advertise support for a language dialect if they don't support it. > >> +#elif __GNUC_PREREQ__(5, 1) > > GCC 3.1? Ooops, I changed this to 5.1 to test the other code path and forgot to revert it. > Last __fpclassifyd should be __fpclassifyl. Fixed. >> @@ -227,8 +250,6 @@ double expm1(double); >> double fma(double, double, double); >> double hypot(double, double); >> int ilogb(double) __pure2; >> -int (isinf)(double) __pure2; >> -int (isnan)(double) __pure2; > > I think they should stay for the C90 case. That would completely defeat the point of this entire exercise and be redundant unless we aim to support a compiler that only supports C90 and no GNU extensions, in which case you'll hit errors in cdefs.h, long before you get to this point in an include. David [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJR3wlaAAoJEKx65DEEsqIdV+gP/jHKkH9K6qTYWJyVj4qLTWE0 1IecE8rEF+mgo53VKFtzcZyO6IAHAvfPkQDk57FjWMmykzkL1hQGFc0w8ncdbiUG 1ETknOrzNO4H4biCZQN/9nvL6UGQB2RAPgJ1eBTypMaes2uIIEx1iy1tl1OyEfRd ohSltgdafnaAnCkM6MSEX3N77Zj5vT7SkzYb3BePkl+fPy/cb1Rdy94w2wUqXWo6 VSDqN0VP0ecWqinNJw58uEV5NAcnN1f1kDxDWCAEBfFWbTOf8V+4r+BO8jQlZG7u Yv52V4pSY592HIJPjlmGIQ+wvzEbuf6jRnjVdZdqGqjziz9gIpUNHRn92p4il7vc bfdljT5nY19RyEzes+7ZIeQlfzzy1GSWcgdnzAyNbpgoGBszMN+ZbsWXQxWShCcN xM7HerErkWcj4E2P4iz5SsNY6Uz9JOhNPtfVu9Zvb359VV3VfDYLf/6MVejTMRGb WaO9O2jPe1RQ9tOH7k7/P6O9u5/sGczK2j3l/Z+UmC8GsoEI9kjTYLOQAKoDTdAx mO6tfc2FEFCVvOZ+WdjWI+7cF0Y3aABAaNKIA47WUP9JBfqCJjPna/82dWknU3iK bvhj3h8puoF2FBoD8/g0K6/3OM+m8W+6veNTwklnV7COvPDMlGCRMCc9GCwLJkzy l5RLiXUcpQcD/qk6mB1D =NvnX -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7D521907-4802-4141-9A5E-40EB157A5AEF>