Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Aug 2018 00:15:40 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r337824 - head/sys/cam
Message-ID:  <201808150015.w7F0Fe9W029006@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Wed Aug 15 00:15:40 2018
New Revision: 337824
URL: https://svnweb.freebsd.org/changeset/base/337824

Log:
  Flesh out a comment about what we're doing with read bias and trims.
  
  Sponsored by: Netflix

Modified:
  head/sys/cam/cam_iosched.c

Modified: head/sys/cam/cam_iosched.c
==============================================================================
--- head/sys/cam/cam_iosched.c	Tue Aug 14 22:57:28 2018	(r337823)
+++ head/sys/cam/cam_iosched.c	Wed Aug 15 00:15:40 2018	(r337824)
@@ -1311,7 +1311,9 @@ cam_iosched_get_trim(struct cam_iosched_softc *isc)
 	if (do_dynamic_iosched) {
 		/*
 		 * If pending read, prefer that based on current read bias
-		 * setting.
+		 * setting. The read bias is shared for both writes and
+		 * TRIMs, but on TRIMs the bias is for a combined TRIM
+		 * not a single TRIM request that's come in.
 		 */
 		if (bioq_first(&isc->bio_queue) && isc->current_read_bias) {
 			isc->current_read_bias--;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808150015.w7F0Fe9W029006>