Date: Thu, 22 Feb 2018 22:49:47 +0000 From: "grehan (Peter Grehan)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D14473: userboot: add callbacks to set unrestricted guest mode Message-ID: <58eedc38683346a20ebf39446e4c5e3f@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org> References: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
grehan accepted this revision. grehan added a comment. You may be able to get away with just the "set" call. Given that all h/w that is supported by bhyve, with the exception of only Nehalem systems, support this, you may want to use just the error from the set call to handle this low-probability error. Note that AMD SVM has always supported this mode. "Unrestricted Guest" is an Intel-only feature, but given that the name is baked into a bhyve API already, there doesn't seem to be any harm in keeping it going. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: fabian.freyer_physik.tu-berlin.de, imp, #bhyve, grehan Cc: grehan, imp, freebsd-virtualization-list, #contributor_reviews_basehelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?58eedc38683346a20ebf39446e4c5e3f>